chore(auth): Improve auth integration test stability and traceability #3143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR attempts to resolve multiple issues to make the Auth integration tests more stable, or at least make it easier to understand the cause of failures.
The Auth integration tests had mostly been implemented with a sequence of operations that looked like this:
or sometimes
This style of testing has a variety of issues:
assertEqualsorfailin a callback to an Amplify API will not fail the test as desired. What actually happens is timing dependent but usually the test process will crash, which may happen in the middle of an execution of a different test, resulting in confusing failures.This PR aims to resolve these issues in the following ways:
CountdownLatch.assertAwaitand particularly around the handling of API subscriptions for receiving OTP codes.How did you test these changes?
Verified tests run successfully when run on my local device.
Documentation update required?
General Checklist
fix(storage): message,feat(auth): message,chore(all): message)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.