Skip to content

Conversation

@ThirdEyeSqueegee
Copy link
Member

@ThirdEyeSqueegee ThirdEyeSqueegee commented Nov 15, 2025

Issue #, if available:
N/A

Description of changes:

  • The nginx image currently defined in the example deployment files isn't accessible from clusters in AWS China regions. Fetch nginx from the ECR Public Gallery to fix this.
  • Format yaml files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ThirdEyeSqueegee ThirdEyeSqueegee requested a review from a team as a code owner November 15, 2025 07:48
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.10%. Comparing base (6dbe3b9) to head (4118174).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   60.10%   60.10%           
=======================================
  Files          11       11           
  Lines         762      762           
=======================================
  Hits          458      458           
  Misses        287      287           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

containers:
- name: nginx-pod-identity-deployment
image: nginx
image: public.ecr.aws/nginx/nginx:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's really only two lines of diff in here, can we remove the formatting changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants