Skip to content

chore: fetch nginx from ECR Public Gallery #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −37
Open

chore: fetch nginx from ECR Public Gallery #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/secrets-store-csi-driver-provider-aws/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ affinity:
- key: "eks.amazonaws.com/compute-type"
operator: NotIn
values:
- fargate
- fargate

resources:
requests:
Expand Down
34 changes: 17 additions & 17 deletions deployment/private-installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ kind: ClusterRole
metadata:
name: csi-secrets-store-provider-aws-cluster-role
rules:
- apiGroups: [""]
resources: ["serviceaccounts/token"]
verbs: ["create"]
- apiGroups: [""]
resources: ["serviceaccounts"]
verbs: ["get"]
- apiGroups: [""]
resources: ["pods"]
verbs: ["get"]
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get"]
- apiGroups: [""]
resources: ["serviceaccounts/token"]
verbs: ["create"]
- apiGroups: [""]
resources: ["serviceaccounts"]
verbs: ["get"]
- apiGroups: [""]
resources: ["pods"]
verbs: ["get"]
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get"]
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
Expand All @@ -32,9 +32,9 @@ roleRef:
kind: ClusterRole
name: csi-secrets-store-provider-aws-cluster-role
subjects:
- kind: ServiceAccount
name: csi-secrets-store-provider-aws
namespace: kube-system
- kind: ServiceAccount
name: csi-secrets-store-provider-aws
namespace: kube-system
---
apiVersion: apps/v1
kind: DaemonSet
Expand All @@ -61,8 +61,8 @@ spec:
image: ${PRIVREPO}
imagePullPolicy: Always
args:
- --provider-volume=/var/run/secrets-store-csi-providers
- --driver-writes-secrets=false
- --provider-volume=/var/run/secrets-store-csi-providers
- --driver-writes-secrets=false
resources:
requests:
cpu: 50m
Expand Down
29 changes: 14 additions & 15 deletions examples/ExampleDeployment-IRSA.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,18 @@ spec:
spec:
serviceAccountName: nginx-irsa-deployment-sa
volumes:
- name: secrets-store-inline
csi:
driver: secrets-store.csi.k8s.io
readOnly: true
volumeAttributes:
secretProviderClass: "nginx-irsa-deployment-aws-secrets"
containers:
- name: nginx-irsa-deployment
image: nginx
ports:
- containerPort: 80
volumeMounts:
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
readOnly: true

csi:
driver: secrets-store.csi.k8s.io
readOnly: true
volumeAttributes:
secretProviderClass: "nginx-irsa-deployment-aws-secrets"
containers:
- name: nginx-irsa-deployment
image: public.ecr.aws/nginx/nginx:latest
ports:
- containerPort: 80
volumeMounts:
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
readOnly: true
4 changes: 2 additions & 2 deletions examples/ExampleDeployment-PodIdentity.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ spec:
secretProviderClass: "nginx-pod-identity-deployment-aws-secrets"
containers:
- name: nginx-pod-identity-deployment
image: nginx
image: public.ecr.aws/nginx/nginx:latest
Copy link
Contributor

@simonmarty simonmarty Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's really only two lines of diff in here, can we remove the formatting changes?

ports:
- containerPort: 80
volumeMounts:
- name: secrets-store-inline
mountPath: "/mnt/secrets-store"
readOnly: true
readOnly: true
4 changes: 2 additions & 2 deletions examples/ExampleSecretProviderClass-IRSA.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ spec:
provider: aws
parameters:
objects: |
- objectName: "MySecret"
objectType: "secretsmanager"
- objectName: "MySecret"
objectType: "secretsmanager"
Loading