Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: schedule the update-release-branch workflow #1351

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

lauzadis
Copy link
Member

@lauzadis lauzadis commented Jul 8, 2024

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lauzadis lauzadis added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jul 8, 2024
@lauzadis lauzadis requested a review from a team as a code owner July 8, 2024 17:49
Copy link

github-actions bot commented Jul 8, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Comment on lines 18 to 19


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: two new lines

Copy link

github-actions bot commented Jul 8, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

This comment has been minimized.

Comment on lines +16 to +17
schedule:
- cron: "0 7 * * 1-5" # At 07:00 UTC (00:00 PST, 03:00 EST), Monday through Friday
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What parameters will this scheduled invocation run with? I see description and dry_run defined and set above but nothing equivalent here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it runs with defaults we could make dry run default to false instead of true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it seems like the inputs will be null when a scheduled action is run.
https://github.com/orgs/community/discussions/74698

I'll update this to set the correct input values

Copy link

sonarqubecloud bot commented Jul 9, 2024

Copy link

github-actions bot commented Jul 9, 2024

A new generated diff is ready to view.

  • No codegen difference in the AWS SDK

Copy link

github-actions bot commented Jul 9, 2024

Affected Artifacts

Changed in size
Artifact Pull Request (bytes) Latest Release (bytes) Delta (bytes) Delta (percentage)
qapps-jvm.jar (does not exist) 1,025,321 -1,025,321 -100.00%
qapps-jvm.jar closure (does not exist) 9,239,322 -9,239,322 -100.00%

@lauzadis lauzadis merged commit f0cf154 into main Jul 9, 2024
17 checks passed
@lauzadis lauzadis deleted the misc-schedule-release-workflow branch July 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants