Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: schedule the update-release-branch workflow #1351

Merged
merged 4 commits into from
Jul 9, 2024
+7 −2
Merged

misc: schedule the update-release-branch workflow #1351

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6473428
Schedule the update-release-branch workflow
lauzadis Jul 8, 2024
f937a83
remove extra newline
lauzadis Jul 8, 2024
a013486
Set dry_run default to false, use `env` to ensure scheduled invocatio…
lauzadis Jul 9, 2024
8183ca9
Capitalize environment variable and use in workflow
lauzadis Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/update-release-branch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,17 @@ on:
description: Dry runs will only attempt to merge but the result will not be pushed to the release branch
required: true
type: boolean
default: true
default: false
schedule:
- cron: "0 7 * * 1-5" # At 07:00 UTC (00:00 PST, 03:00 EST), Monday through Friday
Comment on lines +16 to +17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: What parameters will this scheduled invocation run with? I see description and dry_run defined and set above but nothing equivalent here...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it runs with defaults we could make dry run default to false instead of true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, it seems like the inputs will be null when a scheduled action is run.
https://github.com/orgs/community/discussions/74698

I'll update this to set the correct input values


concurrency:
group: release-manual-${{ github.ref }}
cancel-in-progress: true

env:
DRY_RUN: ${{ github.event.inputs.dry_run || 'false' }

jobs:
update-release:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -89,7 +94,7 @@ jobs:
message=${input_message:-"Merging main into release"}
echo "message=$message"
git merge -m "$message" main;
if [ "${{ inputs.dry_run }}" == "true" ]; then
if [ "${{ env.DRY_RUN }}" == "true" ]; then
echo "dry run, skipping push to remote";
git log -n 10 --oneline;
else
Expand Down
Loading