Skip to content

Conversation

@johnlees
Copy link
Member

Rectangular parts were being transposed to the wrong size, overwriting some elements and leaving others as uninitialised

For future, to test this set an odd sample size and run with chunks = 3 in gpu_api.cpp

python sketchlib-runner.py query dist listeria.h5 --gpu 1

Other notes from build:

  • Used gcc-11 from homebrew, but no longer necessary with newer cuda
  • Need to be added to vglusers group to run CUDA now
  • hdf5 LD_LIBRARY_PATH needs to be set to conda dir
  • export SKETCHLIB_INSTALL=local, and set path and ld_library_path to include nvcc too

Rectangular parts were being transposed to the wrong size, overwriting some elements and leaving others as uninitialised
@johnlees johnlees requested a review from nickjcroucher March 28, 2025 17:13
Copy link
Collaborator

@nickjcroucher nickjcroucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, version bumped, I have installed and compiled, run it on a large dataset on GPU, and the output now behaves more sensibly, thanks for looking into this!

@johnlees johnlees merged commit 4b5a9dc into master Mar 31, 2025
4 checks passed
@johnlees johnlees deleted the gpu-multiblock branch March 31, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants