-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomically set ERC-1967 and enforce implementation invariants #39
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to let this sit a bit, but this kind of mechanism feels helpful. Main downside I see is just proliferating the number of deployed contracts for this system although their implementations and connections are super simple
script/Initialize.s.sol
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will replace these later when development stops
A simpler approach to the
EIP7702Proxy
. Protects vulnerable implementations by enforcing that setting an implementation on the proxy can also be validated to have achieved a desired initialization state or any other specific invariant important to that account, reverting if validation conditions aren't met. This allows us to enforce that a vulnerable implementation is never pointed to in a vulnerable state.Other benefits:
GUARDED_INITIALIZER
initialize
function and streamline withsetImplementation
Proxy
We have 100% test coverage 🎉