-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Atomically set ERC-1967 and enforce implementation invariants #39
Open
amiecorso
wants to merge
13
commits into
main
Choose a base branch
from
amie/atomic-1967-and-ownership
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ee07b69
prototype atomic 1967+ownership updates
amiecorso 55bcef4
EIP7702Proxy approach, need to fix tests
amiecorso 81a527a
tests still broken
amiecorso 51d9e07
overhaul setImplementation tests
amiecorso 5902fbd
overhaul coinbaseImplementation.t.sol
amiecorso 8608bd9
fix constructor.t.sol and delegate.t.sol
amiecorso e069521
all tests passing
amiecorso 604b0ac
run forge fmt
amiecorso 2c4984e
remove log statements
amiecorso 60c8637
renames
amiecorso 4e9e31a
cleanup and more test edge cases
amiecorso 28c1271
add tests for CoinbaseSmartWalletValidator
amiecorso a6b4719
fix imports
amiecorso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity ^0.8.23; | ||
|
||
import {Receiver} from "solady/accounts/Receiver.sol"; | ||
|
||
/// @title DefaultReceiver | ||
/// @notice A concrete implementation of Solady's Receiver contract | ||
/// @dev Handles ETH, ERC721, and ERC1155 token transfers | ||
contract DefaultReceiver is Receiver { | ||
// We don't need to override any functions since the base contract | ||
// already implements all the necessary functionality: | ||
// - receive() for ETH | ||
// - fallback() with receiverFallback modifier for ERC721/ERC1155 | ||
// - _useReceiverFallbackBody() returns true | ||
// - _beforeReceiverFallbackBody() empty implementation | ||
// - _afterReceiverFallbackBody() empty implementation | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will replace these later when development stops