fix: replace newline removal with rstrip for better line handling #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmartmillan
approved these changes
Apr 7, 2025
FedericaBrando
deleted the
fix/47-windows-input-files-not-parsed-properly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an important change to the
_base_parserfunction in theopenvariant/variant/variant.pyfile to improve the handling of line endings in order to parse windows-based text correctly.openvariant/variant/variant.py: Modified the lambda function in the_base_parsermethod to userstrip("\r\n")instead ofreplace("\n", "")for better handling of different line endings.source stackoverflow