Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/293-Update Operation Review Information Page #2390

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

chore/293-Update Operation Review Information Page #2390

wants to merge 11 commits into from

Conversation

ayeshmcg
Copy link
Contributor

@ayeshmcg ayeshmcg commented Oct 18, 2024 •
edited
Loading

Card: bcgov/cas-reporting#293
Changes

  • updated report_version model to have report_type
  • Added API to get report type
  • Updated save report to save report type as well
  • Added conditional rendering of helper text based on operation report type.
    -Added dependency for displaying activities and regulated_products if report type is Annual Report.

@ayeshmcg ayeshmcg force-pushed the chore/293-update-review-operation-information branch 2 times, most recently from f85fcc9 to 246555b Compare October 22, 2024 01:06
@ayeshmcg ayeshmcg marked this pull request as ready for review October 22, 2024 01:06
@ayeshmcg ayeshmcg force-pushed the chore/293-update-review-operation-information branch from 246555b to 938d2a4 Compare October 23, 2024 06:18
@ayeshmcg ayeshmcg force-pushed the chore/293-update-review-operation-information branch from 8db7e1d to fc73628 Compare November 8, 2024 03:13
dleard
dleard approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@dleard dleard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Sorry this took so long to review. A couple really minor things and then this is good to merge!

bc_obps/reporting/api/reports.py Outdated Show resolved Hide resolved
bc_obps/reporting/api/reports.py Outdated Show resolved Hide resolved
bciers/apps/reporting/src/app/components/operations/OperationReviewFormData.tsx Outdated Show resolved Hide resolved
@ayeshmcg ayeshmcg force-pushed the chore/293-update-review-operation-information branch from fc73628 to 094fae7 Compare November 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleard dleard dleard approved these changes

Assignees
No one assigned
Labels
Giraffe 🦒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayeshmcg @dleard