Gate function reflection behind a feature

Author: MrGVSV

Cargo.toml

@@ -348,6 +348,9 @@ ios_simulator = ["bevy_internal/ios_simulator"]
 # Enable built in global state machines
 bevy_state = ["bevy_internal/bevy_state"]
 
+# Enable function reflection
+function_reflection = ["bevy_internal/function_reflection"]
+
 [dependencies]
 bevy_internal = { path = "crates/bevy_internal", version = "0.14.0-dev", default-features = false }
 
@@ -2158,6 +2161,7 @@ wasm = false
 name = "function_reflection"
 path = "examples/reflection/function_reflection.rs"
 doc-scrape-examples = true
+required-features = ["function_reflection"]
 
 [package.metadata.example.function_reflection]
 name = "Function Reflection"

crates/bevy_internal/Cargo.toml

@@ -11,15 +11,15 @@ categories = ["game-engines", "graphics", "gui", "rendering"]
 
 [features]
 trace = [
-  "bevy_app/trace",
-  "bevy_asset?/trace",
-  "bevy_core_pipeline?/trace",
-  "bevy_ecs/trace",
-  "bevy_log/trace",
-  "bevy_pbr?/trace",
-  "bevy_render?/trace",
-  "bevy_hierarchy/trace",
-  "bevy_winit?/trace",
+    "bevy_app/trace",
+    "bevy_asset?/trace",
+    "bevy_core_pipeline?/trace",
+    "bevy_ecs/trace",
+    "bevy_log/trace",
+    "bevy_pbr?/trace",
+    "bevy_render?/trace",
+    "bevy_hierarchy/trace",
+    "bevy_winit?/trace",
 ]
 trace_chrome = ["bevy_log/tracing-chrome"]
 trace_tracy = ["bevy_render?/tracing-tracy", "bevy_log/tracing-tracy"]
@@ -66,29 +66,29 @@ symphonia-wav = ["bevy_audio/symphonia-wav"]
 
 # Shader formats
 shader_format_glsl = [
-  "bevy_render/shader_format_glsl",
-  "bevy_pbr?/shader_format_glsl",
+    "bevy_render/shader_format_glsl",
+    "bevy_pbr?/shader_format_glsl",
 ]
 shader_format_spirv = ["bevy_render/shader_format_spirv"]
 
 serialize = [
-  "bevy_core/serialize",
-  "bevy_input/serialize",
-  "bevy_ecs/serialize",
-  "bevy_time/serialize",
-  "bevy_window/serialize",
-  "bevy_winit?/serialize",
-  "bevy_transform/serialize",
-  "bevy_math/serialize",
-  "bevy_scene?/serialize",
-  "bevy_ui?/serialize",
-  "bevy_color?/serialize",
+    "bevy_core/serialize",
+    "bevy_input/serialize",
+    "bevy_ecs/serialize",
+    "bevy_time/serialize",
+    "bevy_window/serialize",
+    "bevy_winit?/serialize",
+    "bevy_transform/serialize",
+    "bevy_math/serialize",
+    "bevy_scene?/serialize",
+    "bevy_ui?/serialize",
+    "bevy_color?/serialize",
 ]
 multi_threaded = [
-  "bevy_asset?/multi_threaded",
-  "bevy_ecs/multi_threaded",
-  "bevy_render?/multi_threaded",
-  "bevy_tasks/multi_threaded",
+    "bevy_asset?/multi_threaded",
+    "bevy_ecs/multi_threaded",
+    "bevy_render?/multi_threaded",
+    "bevy_tasks/multi_threaded",
 ]
 async-io = ["bevy_tasks/async-io"]
 
@@ -98,37 +98,37 @@ x11 = ["bevy_winit/x11"]
 
 # Transmission textures in `StandardMaterial`:
 pbr_transmission_textures = [
-  "bevy_pbr?/pbr_transmission_textures",
-  "bevy_gltf?/pbr_transmission_textures",
+    "bevy_pbr?/pbr_transmission_textures",
+    "bevy_gltf?/pbr_transmission_textures",
 ]
 
 # Multi-layer material textures in `StandardMaterial`:
 pbr_multi_layer_material_textures = [
-  "bevy_pbr?/pbr_multi_layer_material_textures",
-  "bevy_gltf?/pbr_multi_layer_material_textures",
+    "bevy_pbr?/pbr_multi_layer_material_textures",
+    "bevy_gltf?/pbr_multi_layer_material_textures",
 ]
 
 # Anisotropy texture in `StandardMaterial`:
 pbr_anisotropy_texture = [
-  "bevy_pbr?/pbr_anisotropy_texture",
-  "bevy_gltf?/pbr_anisotropy_texture",
+    "bevy_pbr?/pbr_anisotropy_texture",
+    "bevy_gltf?/pbr_anisotropy_texture",
 ]
 
 # Optimise for WebGL2
 webgl = [
-  "bevy_core_pipeline?/webgl",
-  "bevy_pbr?/webgl",
-  "bevy_render?/webgl",
-  "bevy_gizmos?/webgl",
-  "bevy_sprite?/webgl",
+    "bevy_core_pipeline?/webgl",
+    "bevy_pbr?/webgl",
+    "bevy_render?/webgl",
+    "bevy_gizmos?/webgl",
+    "bevy_sprite?/webgl",
 ]
 
 webgpu = [
-  "bevy_core_pipeline?/webgpu",
-  "bevy_pbr?/webgpu",
-  "bevy_render?/webgpu",
-  "bevy_gizmos?/webgpu",
-  "bevy_sprite?/webgpu",
+    "bevy_core_pipeline?/webgpu",
+    "bevy_pbr?/webgpu",
+    "bevy_render?/webgpu",
+    "bevy_gizmos?/webgpu",
+    "bevy_sprite?/webgpu",
 ]
 
 # enable systems that allow for automated testing on CI
@@ -173,8 +173,8 @@ embedded_watcher = ["bevy_asset?/embedded_watcher"]
 
 # Enable system stepping support
 bevy_debug_stepping = [
-  "bevy_ecs/bevy_debug_stepping",
-  "bevy_app/bevy_debug_stepping",
+    "bevy_ecs/bevy_debug_stepping",
+    "bevy_app/bevy_debug_stepping",
 ]
 
 # Enables the meshlet renderer for dense high-poly scenes (experimental)
@@ -195,6 +195,9 @@ ios_simulator = ["bevy_pbr?/ios_simulator", "bevy_render?/ios_simulator"]
 # Enable built in global state machines
 bevy_state = ["dep:bevy_state"]
 
+# Enable function reflection
+function_reflection = ["bevy_reflect/functions"]
+
 [dependencies]
 # bevy
 bevy_a11y = { path = "../bevy_a11y", version = "0.14.0-dev" }
@@ -210,7 +213,7 @@ bevy_log = { path = "../bevy_log", version = "0.14.0-dev" }
 bevy_math = { path = "../bevy_math", version = "0.14.0-dev" }
 bevy_ptr = { path = "../bevy_ptr", version = "0.14.0-dev" }
 bevy_reflect = { path = "../bevy_reflect", version = "0.14.0-dev", features = [
-  "bevy",
+    "bevy",
 ] }
 bevy_time = { path = "../bevy_time", version = "0.14.0-dev" }
 bevy_transform = { path = "../bevy_transform", version = "0.14.0-dev" }

crates/bevy_reflect/Cargo.toml

@@ -19,6 +19,8 @@ smallvec = ["dep:smallvec"]
 uuid = ["dep:uuid"]
 # When enabled, allows documentation comments to be accessed via reflection
 documentation = ["bevy_reflect_derive/documentation"]
+# Enables function reflection
+functions = ["bevy_reflect_derive/functions"]
 
 [dependencies]
 # bevy

crates/bevy_reflect/derive/Cargo.toml

@@ -15,6 +15,8 @@ proc-macro = true
 default = []
 # When enabled, allows documentation comments to be processed by the reflection macros
 documentation = []
+# Enables macro logic related to function reflection
+functions = []
 
 [dependencies]
 bevy_macro_utils = { path = "../../bevy_macro_utils", version = "0.14.0-dev" }

crates/bevy_reflect/derive/src/impls/enums.rs

@@ -1,6 +1,6 @@
 use crate::derive_data::{EnumVariantFields, ReflectEnum, StructField};
 use crate::enum_utility::{EnumVariantOutputData, TryApplyVariantBuilder, VariantBuilder};
-use crate::impls::{impl_function_traits, impl_type_path, impl_typed};
+use crate::impls::{impl_type_path, impl_typed};
 use bevy_macro_utils::fq_std::{FQAny, FQBox, FQOption, FQResult};
 use proc_macro2::{Ident, Span};
 use quote::quote;
@@ -65,7 +65,11 @@ pub(crate) fn impl_enum(reflect_enum: &ReflectEnum) -> proc_macro2::TokenStream
 
     let type_path_impl = impl_type_path(reflect_enum.meta());
 
-    let function_impls = impl_function_traits(reflect_enum.meta(), &where_clause_options);
+    #[cfg(not(feature = "functions"))]
+    let function_impls = None::<proc_macro2::TokenStream>;
+    #[cfg(feature = "functions")]
+    let function_impls =
+        crate::impls::impl_function_traits(reflect_enum.meta(), &where_clause_options);
 
     let get_type_registration_impl = reflect_enum.get_type_registration(&where_clause_options);
 

crates/bevy_reflect/derive/src/impls/mod.rs

@@ -1,11 +1,13 @@
 mod enums;
+#[cfg(feature = "functions")]
 mod func;
 mod structs;
 mod tuple_structs;
 mod typed;
 mod values;
 
 pub(crate) use enums::impl_enum;
+#[cfg(feature = "functions")]
 pub(crate) use func::impl_function_traits;
 pub(crate) use structs::impl_struct;
 pub(crate) use tuple_structs::impl_tuple_struct;

crates/bevy_reflect/derive/src/impls/structs.rs

@@ -1,4 +1,4 @@
-use crate::impls::{impl_function_traits, impl_type_path, impl_typed};
+use crate::impls::{impl_type_path, impl_typed};
 use crate::utility::ident_or_index;
 use crate::ReflectStruct;
 use bevy_macro_utils::fq_std::{FQAny, FQBox, FQDefault, FQOption, FQResult};
@@ -54,7 +54,11 @@ pub(crate) fn impl_struct(reflect_struct: &ReflectStruct) -> proc_macro2::TokenS
 
     let type_path_impl = impl_type_path(reflect_struct.meta());
 
-    let function_impls = impl_function_traits(reflect_struct.meta(), &where_clause_options);
+    #[cfg(not(feature = "functions"))]
+    let function_impls = None::<proc_macro2::TokenStream>;
+    #[cfg(feature = "functions")]
+    let function_impls =
+        crate::impls::impl_function_traits(reflect_struct.meta(), &where_clause_options);
 
     let get_type_registration_impl = reflect_struct.get_type_registration(&where_clause_options);
 

crates/bevy_reflect/derive/src/impls/tuple_structs.rs

@@ -1,4 +1,4 @@
-use crate::impls::{impl_function_traits, impl_type_path, impl_typed};
+use crate::impls::{impl_type_path, impl_typed};
 use crate::ReflectStruct;
 use bevy_macro_utils::fq_std::{FQAny, FQBox, FQDefault, FQOption, FQResult};
 use quote::{quote, ToTokens};
@@ -46,7 +46,11 @@ pub(crate) fn impl_tuple_struct(reflect_struct: &ReflectStruct) -> proc_macro2::
 
     let type_path_impl = impl_type_path(reflect_struct.meta());
 
-    let function_impls = impl_function_traits(reflect_struct.meta(), &where_clause_options);
+    #[cfg(not(feature = "functions"))]
+    let function_impls = None::<proc_macro2::TokenStream>;
+    #[cfg(feature = "functions")]
+    let function_impls =
+        crate::impls::impl_function_traits(reflect_struct.meta(), &where_clause_options);
 
     let (impl_generics, ty_generics, where_clause) = reflect_struct
         .meta()

crates/bevy_reflect/derive/src/impls/values.rs

@@ -1,4 +1,4 @@
-use crate::impls::{impl_function_traits, impl_type_path, impl_typed};
+use crate::impls::{impl_type_path, impl_typed};
 use crate::utility::WhereClauseOptions;
 use crate::ReflectMeta;
 use bevy_macro_utils::fq_std::{FQAny, FQBox, FQClone, FQOption, FQResult};
@@ -33,7 +33,10 @@ pub(crate) fn impl_value(meta: &ReflectMeta) -> proc_macro2::TokenStream {
 
     let type_path_impl = impl_type_path(meta);
 
-    let function_impls = impl_function_traits(meta, &where_clause_options);
+    #[cfg(not(feature = "functions"))]
+    let function_impls = None::<proc_macro2::TokenStream>;
+    #[cfg(feature = "functions")]
+    let function_impls = crate::impls::impl_function_traits(meta, &where_clause_options);
 
     let (impl_generics, ty_generics, where_clause) = type_path.generics().split_for_impl();
     let where_reflect_clause = where_clause_options.extend_where_clause(where_clause);

crates/bevy_reflect/src/array.rs

@@ -1,4 +1,3 @@
-use crate::func::macros::impl_function_traits;
 use crate::{
     self as bevy_reflect, utility::reflect_hasher, ApplyError, Reflect, ReflectKind, ReflectMut,
     ReflectOwned, ReflectRef, TypeInfo, TypePath, TypePathTable,
@@ -359,7 +358,9 @@ impl Array for DynamicArray {
 }
 
 impl_type_path!((in bevy_reflect) DynamicArray);
-impl_function_traits!(DynamicArray);
+#[cfg(feature = "functions")]
+crate::func::macros::impl_function_traits!(DynamicArray);
+
 /// An iterator over an [`Array`].
 pub struct ArrayIter<'a> {
     array: &'a dyn Array,