Allow SavedAssetBuilder::labeled_assets to store owned strings.

Author: andriyDev

crates/bevy_asset/src/saver.rs

@@ -86,7 +86,7 @@ impl<S: AssetSaver> ErasedAssetSaver for S {
 #[derive(Clone)]
 pub struct SavedAsset<'a, 'b, A: Asset> {
     value: &'a A,
-    labeled_assets: Moo<'b, HashMap<&'a str, LabeledSavedAsset<'a>>>,
+    labeled_assets: Moo<'b, HashMap<CowArc<'a, str>, LabeledSavedAsset<'a>>>,
 }
 
 impl<A: Asset> Deref for SavedAsset<'_, '_, A> {
@@ -100,7 +100,7 @@ impl<A: Asset> Deref for SavedAsset<'_, '_, A> {
 impl<'a, 'b, A: Asset> SavedAsset<'a, 'b, A> {
     fn from_value_and_labeled_saved_assets(
         value: &'a A,
-        labeled_saved_assets: &'b HashMap<&'a str, LabeledSavedAsset<'a>>,
+        labeled_saved_assets: &'b HashMap<CowArc<'a, str>, LabeledSavedAsset<'a>>,
     ) -> Self {
         Self {
             value,
@@ -119,7 +119,7 @@ impl<'a, 'b, A: Asset> SavedAsset<'a, 'b, A> {
                     .iter()
                     .map(|(label, labeled_asset)| {
                         (
-                            label.borrow(),
+                            CowArc::Borrowed(label.borrow()),
                             LabeledSavedAsset::from_labeled_asset(labeled_asset),
                         )
                     })
@@ -203,7 +203,7 @@ impl<'a, 'b, A: Asset> SavedAsset<'a, 'b, A> {
 #[derive(Clone)]
 pub struct ErasedSavedAsset<'a: 'b, 'b> {
     value: &'a dyn AssetContainer,
-    labeled_assets: Moo<'b, HashMap<&'a str, LabeledSavedAsset<'a>>>,
+    labeled_assets: Moo<'b, HashMap<CowArc<'a, str>, LabeledSavedAsset<'a>>>,
 }
 
 impl<'a> ErasedSavedAsset<'a, '_> {
@@ -215,7 +215,10 @@ impl<'a> ErasedSavedAsset<'a, '_> {
                     .labeled_assets
                     .iter()
                     .map(|(label, asset)| {
-                        (label.borrow(), LabeledSavedAsset::from_labeled_asset(asset))
+                        (
+                            CowArc::Borrowed(label.borrow()),
+                            LabeledSavedAsset::from_labeled_asset(asset),
+                        )
                     })
                     .collect(),
             ),
@@ -261,7 +264,7 @@ impl<'a> LabeledSavedAsset<'a> {
 /// This is commonly used in tandem with [`save_using_saver`].
 pub struct SavedAssetBuilder<'a> {
     /// The labeled assets for this saved asset.
-    labeled_assets: HashMap<&'a str, LabeledSavedAsset<'a>>,
+    labeled_assets: HashMap<CowArc<'a, str>, LabeledSavedAsset<'a>>,
     /// The asset path (with no label) that this saved asset is "tied" to.
     ///
     /// All labeled assets will use this asset path (with their substituted labels). Note labeled
@@ -288,11 +291,12 @@ impl<'a> SavedAssetBuilder<'a> {
     /// an asset).
     ///
     /// This is primarily used when **constructing** a new asset to be saved.
-    pub fn add_labeled_asset_with_new_handle<A: Asset>(
+    pub fn add_labeled_asset_with_new_handle<'b: 'a, A: Asset>(
         &mut self,
-        label: &'a str,
+        label: impl Into<CowArc<'b, str>>,
         asset: SavedAsset<'a, 'a, A>,
     ) -> Handle<A> {
+        let label = label.into();
         let handle = Handle::Strong(
             self.asset_server
                 .read_infos()
@@ -313,22 +317,27 @@ impl<'a> SavedAssetBuilder<'a> {
     ///
     /// This is primarily used when attempting to save an existing asset (which already has its
     /// handles populated).
-    pub fn add_labeled_asset_with_existing_handle<A: Asset>(
+    pub fn add_labeled_asset_with_existing_handle<'b: 'a, A: Asset>(
         &mut self,
-        label: &'a str,
+        label: impl Into<CowArc<'b, str>>,
         asset: SavedAsset<'a, 'a, A>,
         handle: Handle<A>,
     ) {
-        self.add_labeled_asset_with_existing_handle_erased(label, asset.upcast(), handle.untyped());
+        self.add_labeled_asset_with_existing_handle_erased(
+            label.into(),
+            asset.upcast(),
+            handle.untyped(),
+        );
     }
 
     /// Same as [`Self::add_labeled_asset_with_new_handle`], but type-erased to allow for dynamic
     /// types.
-    pub fn add_labeled_asset_with_new_handle_erased(
+    pub fn add_labeled_asset_with_new_handle_erased<'b: 'a>(
         &mut self,
-        label: &'a str,
+        label: impl Into<CowArc<'b, str>>,
         asset: ErasedSavedAsset<'a, 'a>,
     ) -> UntypedHandle {
+        let label = label.into();
         let handle = UntypedHandle::Strong(
             self.asset_server
                 .read_infos()
@@ -347,15 +356,15 @@ impl<'a> SavedAssetBuilder<'a> {
 
     /// Same as [`Self::add_labeled_asset_with_existing_handle`], but type-erased to allow for
     /// dynamic types.
-    pub fn add_labeled_asset_with_existing_handle_erased(
+    pub fn add_labeled_asset_with_existing_handle_erased<'b: 'a>(
         &mut self,
-        label: &'a str,
+        label: impl Into<CowArc<'b, str>>,
         asset: ErasedSavedAsset<'a, 'a>,
         handle: UntypedHandle,
     ) {
         // TODO: Check asset and handle have the same type.
         self.labeled_assets
-            .insert(label, LabeledSavedAsset { asset, handle });
+            .insert(label.into(), LabeledSavedAsset { asset, handle });
     }
 
     /// Creates the final saved asset from this builder.
@@ -544,7 +553,7 @@ pub(crate) mod tests {
         let mut asset_labels = saved_asset
             .labeled_assets
             .keys()
-            .copied()
+            .map(|label| label.as_ref().to_string())
             .collect::<Vec<_>>();
         asset_labels.sort();
         assert_eq!(asset_labels, &["goodbye", "hiya", "idk"]);
@@ -634,7 +643,7 @@ pub(crate) mod tests {
         let mut asset_labels = saved_asset
             .labeled_assets
             .keys()
-            .copied()
+            .map(|label| label.as_ref().to_string())
             .collect::<Vec<_>>();
         asset_labels.sort();
         assert_eq!(asset_labels, &["goodbye", "hiya", "idk"]);

examples/asset/asset_saving.rs

@@ -49,15 +49,9 @@ fn perform_save(boxes: Query<(&Sprite, &Transform), With<Box>>, asset_server: Re
     // First we extract all the data needed to produce an asset we can save.
     let boxes = boxes
         .iter()
-        .enumerate()
-        .map(|(index, (sprite, transform))| {
-            (
-                index.to_string(),
-                OneBox {
-                    position: transform.translation.xy(),
-                    color: sprite.color,
-                },
-            )
+        .map(|(sprite, transform)| OneBox {
+            position: transform.translation.xy(),
+            color: sprite.color,
         })
         .collect::<Vec<_>>();
 
@@ -67,11 +61,13 @@ fn perform_save(boxes: Query<(&Sprite, &Transform), With<Box>>, asset_server: Re
             // Build a `SavedAsset` instance from the boxes we extracted.
             let mut builder = SavedAssetBuilder::new(asset_server.clone(), ASSET_PATH.into());
             let mut many_boxes = ManyBoxes { boxes: vec![] };
-            for (label, one_box) in boxes.iter() {
-                many_boxes.boxes.push(
-                    builder
-                        .add_labeled_asset_with_new_handle(label, SavedAsset::from_asset(one_box)),
-                );
+            for (index, one_box) in boxes.iter().enumerate() {
+                many_boxes
+                    .boxes
+                    .push(builder.add_labeled_asset_with_new_handle(
+                        index.to_string(),
+                        SavedAsset::from_asset(one_box),
+                    ));
             }
 
             let saved_asset = builder.build(&many_boxes);