Commit aa14ada
authored
Fix extended_material_bindless example wgpu validation error on MacOS/Metal (#21729)
# Objective
- Fixes #21719
## Solution
- Implementing `bindless_supported` of the `AsBindGroup` trait for
`ExtendedMaterial`:
```rust
fn bindless_supported(render_device: &RenderDevice) -> bool {
B::bindless_supported(render_device) && E::bindless_supported(render_device)
}
```
Before it just returned the default (true), leading to the mismatch.
I made small, mostly stylistic, improvements to `fn
bind_group_layout_entries` and a few other locations like a comment in
`extended_material` during debugging but I could move that out into a
separate PR as well. Since the changes are rather limited and related to
the issue I decided to leave it in for now.
## Testing
- Tested on Windows/NixOS and MacOS, tested multiple examples but most
testing happened on the `extended_material_bindless` and
`extended_material` examples.1 parent 8978b47 commit aa14ada
1 file changed
+18
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
199 | 203 | | |
200 | 204 | | |
201 | 205 | | |
| |||
216 | 220 | | |
217 | 221 | | |
218 | 222 | | |
219 | | - | |
| 223 | + | |
220 | 224 | | |
221 | 225 | | |
222 | 226 | | |
223 | 227 | | |
224 | 228 | | |
225 | 229 | | |
226 | 230 | | |
227 | | - | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
228 | 234 | | |
229 | 235 | | |
230 | 236 | | |
231 | 237 | | |
232 | 238 | | |
233 | 239 | | |
234 | 240 | | |
235 | | - | |
| 241 | + | |
236 | 242 | | |
237 | 243 | | |
238 | 244 | | |
| |||
251 | 257 | | |
252 | 258 | | |
253 | 259 | | |
254 | | - | |
255 | | - | |
256 | | - | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
257 | 266 | | |
258 | | - | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
265 | 270 | | |
266 | 271 | | |
267 | 272 | | |
| |||
0 commit comments