About the new bevy::render::FrameCountPlugin

[phuocthanhdo]

Hi, I was wondering why the FrameCount is only increment with a system in bevy::render crate?

It leads to the FrameTimeDiagnosticsPlugin cannot update frame_count without adding the FrameCountPlugin.

1. The app will need to pull a lot dependencies from bevy::render to add FrameCountPlugin.
2. Or manually fix FrameTimeDiagnosticsPlugin by making another system like that if don't want to import bevy::render crate

[alice-i-cecile]

This was due to timing consistency challenges IIRC. Decision was made by @hymm. Perhaps we should reorganize where this system is stored, and then call it from bevy_render?

[phuocthanhdo]

Or we can completely remove the frame_count from the FrameTimeDiagnostics, I think the diagnostics is working fine without it. Current version (0.9), the FrameTimeDiagnostics always return frame_count = 0.

[alice-i-cecile]

Yeah, I'd be happy to see that. Make a PR?

[mockersf]

the FrameTimeDiagnostics always return frame_count = 0.

No? It works for me and has the correct frame count

[phuocthanhdo]

the FrameTimeDiagnostics always return frame_count = 0.

No? It works for me and has the correct frame count

If you include DefaultPlugins in the app, with default_features, yes. But as hymm point out, the update_frame_count is running from RenderPlugin, so for server side (no render) it doesn't work.

[phuocthanhdo]

Yeah, I'd be happy to see that. Make a PR?

Yeah. I will open a PR

[phuocthanhdo]

Just open #6676 for moving update_frame_count system

And I found a bit more detail about the source of change:

#5409 (comment)