Skip to content

Conversation

@effigies
Copy link
Collaborator

Following up on decision made in Copenhagen. This "is" was interpreted by some to be a requirement, but this has never been validated, would be breaking to turn into an error, and is impractical to encode in the schema. Rather than contort ourselves to devise a check, it makes more sense to use RFC 2119 language to make clear that this is an optional convention, not a requirement.

Closes #2081.

@effigies effigies requested a review from erdalkaraca as a code owner August 22, 2025 14:46
@effigies effigies added this to the 1.10.1 milestone Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.71%. Comparing base (db1c087) to head (eef53a0).
⚠️ Report is 147 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2179   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files          20       20           
  Lines        1608     1608           
=======================================
  Hits         1330     1330           
  Misses        278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@neuromechanist neuromechanist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Actually, I had someone reach out about this very sentence separately, agreed that May works best

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me.

@effigies effigies merged commit e392de6 into bids-standard:master Aug 27, 2025
28 checks passed
@effigies effigies deleted the taskname-clarification branch August 27, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify relation of task entity to TaskName metadata using RFC 2119 MUST/SHOULD/MAY language

3 participants