Skip to content

Conversation

@cutpatel
Copy link
Contributor

Update to version 1.1.0
changed test command
changed picard requirements

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

Update to version 1.1.0
changed test command
changed picard requirements
@cutpatel
Copy link
Contributor Author

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Aug 23, 2023
@mencian mencian merged commit ae7a1af into master Aug 24, 2023
@mencian mencian deleted the update_mtbseq branch August 24, 2023 04:20
@cutpatel
Copy link
Contributor Author

May I ask why the meta.yaml was changed? I think the before version was cleaner and actually was suggested to do so at the inital package creation by johanneskoester. #11042

@rpetit3
Copy link
Member

rpetit3 commented Sep 11, 2023

Hi @cutpatel

I opted for {{ version }} to make it consistent with many other recipes, really just an attempt to make it more familiar for others.

I think either is fine, please feel free to change it! If you do, do not hesitate to request me as a reviewer.

Thank you for your work on mtbseq!

Cheers,
Robert

@cutpatel
Copy link
Contributor Author

Hi @rpetit3

thank you for your answer! Ok, just wanted to see if there was some kind of "violation". Maybe I change it back with an next update. But it also seems this discussion about the variables was never finished with a result bioconda/bioconda-utils#339. ; )

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please review & merge set to ask for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants