Skip to content

fix issues with weaver logging #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fmigneault merged 5 commits into from
Jan 16, 2026
Merged

fix issues with weaver logging #634

fmigneault merged 5 commits into from
Jan 16, 2026

Conversation

@mishaschwartz
Copy link
Collaborator

@mishaschwartz mishaschwartz commented Jan 14, 2026 •
edited
Loading

Overview

Instead of commenting on #622 it's easier to just make the logging changes as a separate PR here and explain the issues that this is solving (see comments below).

@fmigneault

Changes

Non-breaking changes

  • logging fixes

Breaking changes

Related Issue / Discussion

Additional Information

CI Operations

birdhouse_daccs_configs_branch: master
birdhouse_skip_ci: false

@github-actions github-actions bot added ci/deployment Related to deployment utilities and scripts component/weaver Related to https://github.com/crim-ca/weaver feature/WPS Feature or service related to Web Processing Service labels Jan 14, 2026
@crim-jenkins-bot
Copy link
Collaborator

crim-jenkins-bot commented Jan 14, 2026

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3956/
Result 🆘 ABORTED

BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-logging-issues
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

⚠️ Infrastructure deployment failed. ⚠️
Instance destroyed due to CI execution.
To debug, launch an instance manually with PR reference fix-weaver-logging-issues.

mishaschwartz
mishaschwartz commented Jan 14, 2026
View reviewed changes
@crim-jenkins-bot
Copy link
Collaborator

crim-jenkins-bot commented Jan 14, 2026

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3957/
Result 🆘 ABORTED

BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-logging-issues
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

⚠️ Infrastructure deployment failed. ⚠️
Instance destroyed due to CI execution.
To debug, launch an instance manually with PR reference fix-weaver-logging-issues.

@mishaschwartz mishaschwartz mentioned this pull request Jan 14, 2026
Open
@crim-jenkins-bot
Copy link
Collaborator

crim-jenkins-bot commented Jan 14, 2026

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3958/
Result 🆘 ABORTED

BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-logging-issues
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

⚠️ Infrastructure deployment failed. ⚠️
Instance destroyed due to CI execution.
To debug, launch an instance manually with PR reference fix-weaver-logging-issues.

fmigneault
fmigneault reviewed Jan 14, 2026
View reviewed changes
Copy link
Member

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just validating other cases.

@crim-jenkins-bot
Copy link
Collaborator

crim-jenkins-bot commented Jan 15, 2026

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3962/
Result 🆘 ABORTED

BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-logging-issues
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-154.rdext.crim.ca

⚠️ Infrastructure deployment failed. ⚠️
Instance destroyed due to CI execution.
To debug, launch an instance manually with PR reference fix-weaver-logging-issues.

tlvu
tlvu approved these changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as-is but it would be nice if tests could be added for the new feature.

@github-actions github-actions bot added ci/operations Continuous Integration components ci/tests Issues or changes related to tests scripts labels Jan 16, 2026
@crim-jenkins-bot
Copy link
Collaborator

crim-jenkins-bot commented Jan 16, 2026

E2E Test Results

DACCS-iac Pipeline Results

Build URL : http://daccs-jenkins.crim.ca:80/job/DACCS-iac-birdhouse/3964/
Result 🆘 ABORTED

BIRDHOUSE_DEPLOY_BRANCH : fix-weaver-logging-issues
DACCS_IAC_BRANCH : master
DACCS_CONFIGS_BRANCH : master
PAVICS_E2E_WORKFLOW_TESTS_BRANCH : master
PAVICS_SDI_BRANCH : master

DESTROY_INFRA_ON_EXIT : true
PAVICS_HOST : https://host-140-91.rdext.crim.ca

⚠️ Infrastructure deployment failed. ⚠️
Instance destroyed due to CI execution.
To debug, launch an instance manually with PR reference fix-weaver-logging-issues.

@fmigneault fmigneault merged commit d8b4418 into security-updates Jan 16, 2026
4 of 5 checks passed
@fmigneault fmigneault deleted the fix-weaver-logging-issues branch January 16, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlvu tlvu tlvu approved these changes

@fmigneault fmigneault fmigneault approved these changes

Assignees

No one assigned

Labels

ci/deployment Related to deployment utilities and scripts ci/operations Continuous Integration components ci/tests Issues or changes related to tests scripts component/weaver Related to https://github.com/crim-ca/weaver feature/WPS Feature or service related to Web Processing Service

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mishaschwartz @crim-jenkins-bot @tlvu @fmigneault