Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return Fatal error on bls precompiles if in no_std #2249

Merged

Conversation

nemnem7
Copy link
Contributor

@nemnem7 nemnem7 commented Mar 18, 2025

closes #2208

Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #2249 will not alter performance

Comparing nemnem7:nem/fatal_error_on_bls_precomp_if_no_std (ab410f6) with main (c275ddf)

Summary

✅ 8 untouched benchmarks

@rakita rakita changed the title nem/Return Fatal error on bls precompiles if in no_std feat: Return Fatal error on bls precompiles if in no_std Mar 19, 2025
@nemnem7
Copy link
Contributor Author

nemnem7 commented Mar 19, 2025

I updated the addresses' type (they are now of type Address, not u64) and function arguments in optimism/src/evm.rs where the addresses are used as function arguments

@nemnem7 nemnem7 requested a review from rakita March 19, 2025 12:14
@rakita rakita merged commit 8ed1b16 into bluealloy:main Mar 19, 2025
28 checks passed
@nemnem7 nemnem7 deleted the nem/fatal_error_on_bls_precomp_if_no_std branch March 19, 2025 12:29
@github-actions github-actions bot mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Fatal error on bls precompiles if in no_std
2 participants