Handle errors building queries from request #1235
Open
+4
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception being caught (QueryValueError) was never being raised and the TypeErrors being raised instead caused 503 server errors when fields were missing or invalid. Catching TypeError instead allows the client to get a `400 Bad Request` error with the exception detail as intended.
Contributor
Author
|
Alternatively, I'm happy to modify the query types instead to raise |
tpoliaw
changed the title
Contributor
Author
|
Pinned both fastapi and minio to avoid breaking changes in recent versions minio breaking change in patch release here I think both should be in a different PR but I wanted to check the CI for this change first |
Member
|
I see last night's scheduled run failed over this. Thanks for looking into it @tpoliaw. |
Member
|
CI is green again now, and I did a release (v0.2.2). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception being caught (QueryValueError) was never being raised and
the TypeErrors being raised instead caused 503 server errors when fields
were missing or invalid. Catching TypeError instead allows the client to
get a
400 Bad Requesterror with the exception detail as intended.