Skip to content

Handle errors building queries from request #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle errors building queries from request #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f162e4
Handle errors building queries URL query
tpoliaw Nov 24, 2025
3cf1191
Pin version with breaking changes
tpoliaw Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ all = [
"dask[dataframe]",
"duckdb <1.4.0", # https://github.com/bluesky/tiled/issues/1144
"entrypoints",
"fastapi >=0.115.8",
"fastapi >=0.115.8,<0.122",
"h5netcdf",
"h5py",
"hdf5plugin",
Expand Down Expand Up @@ -245,7 +245,7 @@ server = [
"jinja2",
"jmespath",
"lz4",
"minio",
"minio != 7.2.19",
"ndindex",
"numba >=0.59.0", # indirect, pinned to assist uv solve
"numcodecs",
Expand Down
4 changes: 0 additions & 4 deletions tiled/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,3 @@ def __ge__(self, value):
# Note: __contains__ cannot be supported because the language coerces
# the result of __contains__ to be a literal boolean. We are not
# allowed to return a custom type.


class QueryValueError(ValueError):
pass
4 changes: 2 additions & 2 deletions tiled/server/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from .. import queries
from ..adapters.mapping import MapAdapter
from ..links import links_for_node
from ..queries import KeyLookup, QueryValueError
from ..queries import KeyLookup
from ..serialization import register_builtin_serializers
from ..structures.core import Spec, StructureFamily
from ..utils import (
Expand Down Expand Up @@ -184,7 +184,7 @@ async def apply_search(tree, filters, query_registry):
key_lookups.append(query.key)
continue
tree = tree.search(query)
except QueryValueError as err:
except TypeError as err:
raise HTTPException(
status_code=HTTP_400_BAD_REQUEST, detail=err.args[0]
)
Expand Down