-
Notifications
You must be signed in to change notification settings - Fork 20
added support for geojson format url #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
added support for geojson format url #73
Conversation
|
👷 Deploy request for raster-playground pending review. 🔨 Explore the source changes: aa98a16 |
|
leave feedback so i can improve as soon as possible |
| function get_url_extension(url) { | ||
| return url.split(/[#?]/)[0].split('.').pop().trim(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if data comes from non-extension API?
I think some other approach is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must get that data and check whether this is a GeoJSON or TopoJSON.
And based on that you should pass the map feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
refactor all changes, review and task for next round |
|
Review this |
|
ok but ui on my side is correct |
|
today I am working on the second task of clip instead of layer |
|
https://gifted-elion-321a04.netlify.app review for changes |
|
review for changes |



add support for geoJSON file format