Skip to content

added support for geojson format url #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

added support for geojson format url #73

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6bfb9d1
added support for geojson format url
shivamSspirit Nov 10, 2021
0faa5f6
upload file and select url of topojson and geojson files
shivamSspirit Nov 29, 2021
ef5b8f1
refactoring to clipping insted of adding layer
shivamSspirit Dec 25, 2021
d4672be
remove spaces
shivamSspirit Dec 25, 2021
e5c033f
update npm
shivamSspirit Dec 25, 2021
01b6550
refator pkg version
shivamSspirit Dec 25, 2021
c1df609
make button aligned on some mobile screens
shivamSspirit Dec 26, 2021
aa98a16
refator clipping and make make alignment of button
shivamSspirit Dec 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/components/main-app/ol/clip-raster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,23 @@
import { Vector as VectorLayer } from 'ol/layer';
import { Vector as VectorSource } from 'ol/source';
import { TopoJSON } from 'ol/format';
import { GeoJSON, TopoJSON } from 'ol/format';
import { getVectorContext } from 'ol/render';
import { Fill, Style, Stroke } from 'ol/style';

/**
* @param {*} rasterLayer = Raster layer map instance generated from OL map init
*/

function get_url_extension(url) {
return url.split(/[#?]/)[0].split('.').pop().trim();
}
Copy link
Contributor

@srijitcoder srijitcoder Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if data comes from non-extension API?
I think some other approach is needed.

Copy link
Contributor

@srijitcoder srijitcoder Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must get that data and check whether this is a GeoJSON or TopoJSON.
And based on that you should pass the map feature.

Copy link
Author

@shivamSspirit shivamSspirit Dec 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


export default function clipRasterLayer({ rasterLayer, shape }) {
//Create cliping layer from topojson
const urlExtension = get_url_extension(shape);

const shapeSource = new VectorSource({
url: shape,
format: new TopoJSON(),
format: urlExtension === 'geojson' ? new GeoJSON() : new TopoJSON(),
overlaps: false,
});

Expand Down