Miscellaneous fixes #111
Merged
Miscellaneous fixes #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varunagrawal
added
bugfix
dellaert
requested changes
Mar 30, 2021
| @@ -1,160 +1,78 @@ | |||
| <robot name="fetch"> | |||
| <?xml version="1.0" ?> | |||
There was a problem hiding this comment.
Why are you getting rid of visuals?
There was a problem hiding this comment.
Sdformat8 parser complains about it since the geometry tag points to an external resource which is not available in the repo (it's available on the fetch repo which is why it works there).
gchenfc
approved these changes
Apr 2, 2021
|
I don't think it's possible because it is an exception thrown by sdformat which prevents loading the URDF altogether. Although, it seems like SDFormat9/10 has support for the mesh tag so it would be interesting to see if we can get this to work after we land #48. @dellaert we may want to raise the priority of #48 given all the blocking it is doing for us. |
|
Please keep a version of the file with the meshes. Then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some niceties.
I also fixed #12.