Skip to content

Conversation

@koooosh
Copy link
Contributor

@koooosh koooosh commented Nov 12, 2025

Issue number:

N/A

Description of changes:

Updating the check-migrations task with another test validating all version transitions are present in Release.toml.

Testing done:

Built custom twoliter binary and ran check which resulted in the expected failure:

$ cargo make -e=TWOLITER_ALLOW_SOURCE_INSTALL=false -e=TWOLITER_ALLOW_BINARY_INSTALL=false -e=TWOLITER_SKIP_VERSION_CHECK=true   check
...
[cargo-make][1] INFO - Running Task: check-migrations
Found 1 problem(s) with data store migrations:
    - Missing version transition: (1.47.0, 1.48.0)
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105
Error while executing command, exit code: 1

Additional test case for skipped version:

[cargo-make][1] INFO - Running Task: check-migrations
Found 1 problem(s) with data store migrations:
    - Skipped version in transition (0.3.2, 0.3.4) - expected 0.3.3
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105
Error while executing command, exit code: 1

Additional test case where there is no migration for a new release version:

$ cargo make -e=TWOLITER_ALLOW_SOURCE_INSTALL=false -e=TWOLITER_ALLOW_BINARY_INSTALL=false -e=TWOLITER_SKIP_VERSION_CHECK=true   check-migrations
Found 1 problem(s) with data store migrations:
    - Last transition ends at 1.51.0, but current version is 1.52.0
Error while executing command, exit code: 1
Error: Command was unsuccessful, exit code 105
Error while executing command, exit code: 1

After fix in Release.toml:

[cargo-make][1] INFO - Running Task: check-migrations
[cargo-make][1] INFO - Build Done in 6.53 seconds.
[cargo-make] INFO - Build Done in 10.85 seconds.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@koooosh koooosh requested review from cbgbt and jmt-lab November 18, 2025 19:56
@koooosh koooosh force-pushed the migration-version-validation branch from 9a938ab to 13daaca Compare November 20, 2025 04:20
@koooosh
Copy link
Contributor Author

koooosh commented Nov 20, 2025

Force push makes improvements recommended by @cbgbt

@koooosh koooosh force-pushed the migration-version-validation branch from 13daaca to 3114e38 Compare November 20, 2025 18:53
@koooosh
Copy link
Contributor Author

koooosh commented Nov 20, 2025

Force push adds another check for skipped versions as per @piyush-jena feedback

@koooosh koooosh requested a review from piyush-jena November 20, 2025 18:55
Copy link

@piyush-jena piyush-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes!

@koooosh koooosh merged commit 7e51780 into bottlerocket-os:develop Nov 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants