Skip to content

feat: support zeebe:formDefinition, zeebe:calledDecision, bpmn:ScriptTask with zeebe:script and zeebe:taskDefinition #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

yT0n1
Copy link
Contributor

@yT0n1 yT0n1 commented Jun 25, 2025

Proposed Changes

Add element template support for zeebe:formDefinition, zeebe:calledDecision, bpmn:ScriptTask with zeebe:script and zeebe:taskDefinition

Bumps schema version.

related to camunda/camunda-modeler#5073
related to camunda/camunda-modeler#5025
related to camunda/camunda-modeler#5026

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jun 25, 2025
@yT0n1 yT0n1 marked this pull request as ready for review June 25, 2025 14:47
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 25, 2025
@yT0n1 yT0n1 requested review from Copilot and barmac June 25, 2025 14:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for new Zeebe element template bindings (formDefinition, calledDecision, script and taskDefinition) and updates the schema version.

  • Extend the validator’s allowed binding types and bump the JSON schema dependency.
  • Introduce validation tests and fixtures for form definitions, called decisions, and script tasks (including valid, broken, and job-worker variants).
  • Update package.json to use schema version ^0.24.0.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/spec/validationSpec.js Extend allowed types in error message and add new tests
test/fixtures/form-definition.json Add valid form-definition template fixtures
test/fixtures/form-definition-broken.json Add broken form-definition fixtures
test/fixtures/called-decision.json Add valid called-decision template fixtures
test/fixtures/called-decision-broken.json Add broken called-decision fixtures
test/fixtures/script-task.json Add valid script-task template fixtures
test/fixtures/script-task-broken.json Add broken script-task fixtures
test/fixtures/script-task-job-worker.json Add script-task job-worker fixtures
package.json Bump @camunda/zeebe-element-templates-json-schema
Comments suppressed due to low confidence (2)

test/fixtures/form-definition.json:1

  • This fixture omits the $schema declaration at the top. Adding the JSON schema reference would keep it consistent with other fixtures and improve editor tooling support.
[

test/fixtures/script-task-broken.json:122

  • [nitpick] The id uses mixed casing (resultVariable). For consistency with other IDs, consider using kebab-case (script-task-missing-result-variable).
    "id": "script-task-missing-resultVariable",

feat: support zeebe:formDefinition

Related to camunda/camunda-modeler#5073

feat: support zeebe:calledDecision

Related to camunda/camunda-modeler#5025

feat: support bpmn:ScriptTask with zeebe:script and zeebe:taskDefinition

Related to camunda/camunda-modeler#5026
@barmac barmac force-pushed the extended-et-support branch from 1a79b4f to c0721ba Compare June 26, 2025 06:47
@barmac barmac merged commit bdddf2f into main Jun 26, 2025
3 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 26, 2025
@barmac barmac deleted the extended-et-support branch June 26, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants