Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call AuthorizeAndPlayURI on main thread #221

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Call AuthorizeAndPlayURI on main thread #221

merged 3 commits into from
Oct 3, 2024

Conversation

haashem
Copy link
Contributor

@haashem haashem commented Oct 3, 2024

Related to #218

The previous PR accidentally closed because of branch reset.

fotiDim
fotiDim reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@fotiDim fotiDim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small indentation fix needed

ios/Classes/SwiftSpotifySdkPlugin.swift Outdated Show resolved Hide resolved
@haashem haashem marked this pull request as draft October 3, 2024 21:30
@haashem haashem marked this pull request as ready for review October 3, 2024 21:33
@fotiDim fotiDim merged commit 20d6f85 into brim-borium:main Oct 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fotiDim fotiDim fotiDim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haashem @fotiDim