Fix Issue #350: Add test case for verifying the IfcMaterialLayerSet name (LayerSetName) in material test cases #351
Conversation
There was a problem hiding this comment.
Hello @giuseppeverduciALMA,
Aren't these match expression a bit too broad? I'm concerned the will end up excluding useful files
There was a problem hiding this comment.
You're right to point that out; I see how the match expressions in the .gitignore could potentially be too broad. The intent was to exclude only generated and compiled files specific to the build process, especially those in the SchemaProject and build directories, which are recreated with each compilation and don't exist in the source repository.
For example, with a modification like this:
build/bin
build/obj
SchemaProject/bin
SchemaProject/obj
we would exclude only the files resulting from the compilation while still allowing the commit of the SchemaProject/Ids.cs file, which is autogenerated (would it be helpful to keep this file?).
How could we further refine these expressions to minimize any risk of excluding useful files?
There was a problem hiding this comment.
I think we already have similar matches in the current gitignore, I wonder if you need a local "git clean -xdf" and see if you still have undesired artifacts after compilation.
There was a problem hiding this comment.
I've removed the two entries from the .gitignore after running the clean command. Thanks for the guidance!
This pull request addresses the missing test case for verifying the name (LayerSetName) of the IfcMaterialLayerSet element in the material test cases (Issue #350).
Changes: