Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue #350: Add test case for verifying the IfcMaterialLayerSet name (LayerSetName) in material test cases #351

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Fix Issue #350: Add test case for verifying the IfcMaterialLayerSet name (LayerSetName) in material test cases #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3373b43
Ignore build and SchemaProject files in .gitignore
giuseppeverduciALMA Sep 27, 2024
c644a1e
Add test case for verifying the IfcMaterialLayerSet LayerSetName in m…
giuseppeverduciALMA Sep 27, 2024
aa0e1fc
Remove build and SchemaProject entries from .gitignore
giuseppeverduciALMA Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @giuseppeverduciALMA,

Aren't these match expression a bit too broad? I'm concerned the will end up excluding useful files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right to point that out; I see how the match expressions in the .gitignore could potentially be too broad. The intent was to exclude only generated and compiled files specific to the build process, especially those in the SchemaProject and build directories, which are recreated with each compilation and don't exist in the source repository.

For example, with a modification like this:

build/bin
build/obj
SchemaProject/bin
SchemaProject/obj

we would exclude only the files resulting from the compilation while still allowing the commit of the SchemaProject/Ids.cs file, which is autogenerated (would it be helpful to keep this file?).

How could we further refine these expressions to minimize any risk of excluding useful files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have similar matches in the current gitignore, I wonder if you need a local "git clean -xdf" and see if you still have undesired artifacts after compilation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the two entries from the .gitignore after running the clean command. Thanks for the guidance!

Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@
/RepositoryAutomation/SchemaProject/bin/
/RepositoryAutomation/SchemaProject/obj/
/RepositoryAutomation/SchemaProject/Ids.cs
.DS_Store

.DS_Store
25 changes: 25 additions & 0 deletions ...mentersDocumentation/TestCases/material/pass-a_layer_set_name_will_pass_a_value_check.ids
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="utf-8"?>
<ids xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://standards.buildingsmart.org/IDS http://standards.buildingsmart.org/IDS/1.0/ids.xsd" xmlns="http://standards.buildingsmart.org/IDS">
<info>
<title>A layer set name will pass the value check</title>
<description>Generated via code automation in the Ids Repository on github.</description>
</info>
<specifications>
<specification name="A layer set name will pass the value check" ifcVersion="IFC2X3 IFC4">
<applicability maxOccurs="unbounded">
<entity>
<name>
<simpleValue>IFCWALL</simpleValue>
</name>
</entity>
</applicability>
<requirements>
<material>
<value>
<simpleValue>Bar</simpleValue>
</value>
</material>
</requirements>
</specification>
</specifications>
</ids>
14 changes: 14 additions & 0 deletions ...mentersDocumentation/TestCases/material/pass-a_layer_set_name_will_pass_a_value_check.ifc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
ISO-10303-21;
HEADER;
FILE_DESCRIPTION(('ViewDefinition [CoordinationView]'),'2;1');
FILE_NAME('','2022-10-07T13:48:44',(),(),'IfcOpenShell v0.7.0-dc67287d','IfcOpenShell v0.7.0-dc67287d','');
FILE_SCHEMA(('IFC4'));
ENDSEC;
DATA;
#1=IFCWALL('1hqIFTRjfV6AWq_bMtnZwI',$,$,$,$,$,$,$,$);
#2=IFCMATERIALLAYERSET((#5),'Bar',$);
#3=IFCRELASSOCIATESMATERIAL('05rScmOVzMoQXOfbYdtLYj',$,$,$,(#1),#2);
#4=IFCMATERIAL('Unnamed',$,$);
#5=IFCMATERIALLAYER(#4,1.,$,'Foo',$,$,$);
ENDSEC;
END-ISO-10303-21;
9 changes: 9 additions & 0 deletions Documentation/ImplementersDocumentation/TestCases/scripts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1422,6 +1422,15 @@ Requirements:
Material: ''Foo''
```

### A layer set name will pass the value check

``` ids material/pass-a_layer_set_name_will_pass_a_value_check.ids
A layer set name will pass the value check
Entity: ''IFCWALL''
Requirements:
Material: ''Bar''
```

## partof

### A group entity must match exactly 1/2
Expand Down
Loading