Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cfg loader #5

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Feat/cfg loader #5

merged 10 commits into from
Nov 7, 2023

Conversation

y-eight
Copy link
Contributor

@y-eight y-eight commented Oct 27, 2023 •
edited
Loading

Motivation

The configuration for the checks that can be registered needs to be loaded from a remote source. Therefore the Loader interface has been created. One specific Loader can be registered. Each Loader implementation could get the configuration from different sources.

Changes

  • Loader interface with first HttpLoader implementation added
  • Sparrow registered checks will be set via map (was a slice before)
    • The name field has been removed from the checks
  • Reconciliation functionality has been implemented to (re)register and remove checks from sparrow

For additional information look at the commits.

Tests done

  • unit tests provided

@y-eight y-eight self-assigned this Oct 27, 2023
@y-eight y-eight mentioned this pull request Oct 31, 2023
Merged
lvlcn-t
lvlcn-t reviewed Nov 4, 2023
View reviewed changes
Copy link
Member

@lvlcn-t lvlcn-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you could improve some small things, let me know what you think. 🙂

pkg/checks/roundtrip.go Outdated Show resolved Hide resolved
pkg/sparrow/run.go Outdated Show resolved Hide resolved
pkg/sparrow/run.go Outdated Show resolved Hide resolved
pkg/sparrow/run.go Show resolved Hide resolved
pkg/sparrow/run.go Outdated Show resolved Hide resolved
@y-eight y-eight requested a review from lvlcn-t November 4, 2023 13:19
lvlcn-t

This comment was marked as outdated.

Sign in to view

niklastreml
niklastreml requested changes Nov 6, 2023
View reviewed changes
pkg/config/config.go Outdated Show resolved Hide resolved
pkg/config/gitlab.go Outdated Show resolved Hide resolved
pkg/config/loader.go Outdated Show resolved Hide resolved
pkg/sparrow/run.go Outdated Show resolved Hide resolved
pkg/sparrow/run.go Outdated Show resolved Hide resolved
@y-eight y-eight merged commit b451cd7 into main Nov 7, 2023
1 check passed
@lvlcn-t lvlcn-t deleted the feat/cfg-loader branch November 8, 2023 13:56
@lvlcn-t lvlcn-t added the feature Introduces a new feature label Dec 6, 2023
lvlcn-t pushed a commit that referenced this pull request Jan 29, 2024
@JTaeuber
feat: added new workflow to prune old images (#88)
3f5416b 
* feat: added workflow to prune old images (#1)

* fix: added runs-on variable (#2)

* feat: trying new regex (#3)

* fix: trying commit as expression (#4)

* fix: trying keep tags (#5)

* beingtoospecific (#6)

* fix: regex expression fixed (#7)

* fix: new regex (#8)

* Test (#9)

* fix: new regex

* test

* fix: fixed regex hopefully (#10)

* fix: pruning snapshots (#11)

* feat: added new workflow to prune old images for packages sparrow and charts/sparrow

* fix: removed keep-last conditions

* fix: removed comments

* fix: removed unnecessary permission declaration

* fix: removed dry-run
@lvlcn-t lvlcn-t mentioned this pull request Feb 2, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvlcn-t lvlcn-t lvlcn-t approved these changes

@niklastreml niklastreml niklastreml approved these changes

Assignees

@y-eight y-eight

Labels
feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-eight @niklastreml @lvlcn-t