Apply suggestions from code review

Co-authored-by: Stephanie Eng <[email protected]>
cactusdynamics · Jul 25, 2024 · 089cbbb · 089cbbb
1 parent 04969a8
commit 089cbbb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docs/tracing.md b/docs/tracing.md
@@ -219,7 +219,7 @@ If tracing is not enabled right now, the `TraceAggregator` will cache the
 is written out.
 
 The `Thread` is able to communicate with the `TraceAggregator` by storing a
-`weak_ptr` to the `TraceAggregator`. This pointer is setup during
+`weak_ptr` to the `TraceAggregator`. This pointer is set up during
 `App::RegisterThread` so there's no explicit dependency between `Thread` and
 `App` during construction.  This decision may be revisited in the future.
 
@@ -255,7 +255,7 @@ noting:
    (i.e. thus `(trusted_packet_sequence_id, iid)` is sufficient to identify an
    interned string). This, along with (1), implies we have to intern strings on
    a per-thread interner.
-3. When a tracing session stop, the string interner states for all known thread
+3. When a tracing session stops, the string interner states for all known thread
    tracers are reset. This means a subsequent session will not have the same
    string iids.
 

diff --git a/include/cactus_rt/tracing/thread_tracer.h b/include/cactus_rt/tracing/thread_tracer.h
@@ -1,14 +1,14 @@
 #ifndef CACTUS_TRACING_THREAD_TRACER_H_
 #define CACTUS_TRACING_THREAD_TRACER_H_
 
-#include <atomic>
 #ifndef CACTUS_RT_TRACING_ENABLED
 #include "thread_tracer.disabled.h"
 #else
 
 #include <readerwriterqueue.h>
 #include <unistd.h>
 
+#include <atomic>
 #include <cstdint>
 
 #include "../experimental/lockless/atomic_message.h"