Handle runtime context #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabe-l-hart
requested review from
tjohnson31415,
hickeyma,
alex-jw-brooks,
gkumbhat,
evaline-ju and
joerunde
as code owners
1 task
gabe-l-hart
commented
Jun 19, 2024
gkumbhat
reviewed
Jun 19, 2024
Since the context parsing needs to happen in the backend directly, this needs to live here now Signed-off-by: Gabe Goodhart <[email protected]>
…rsing Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
Signed-off-by: Gabe Goodhart <[email protected]>
gabe-l-hart
force-pushed
the
HandleRuntimeContext
branch
from
b0b51c9
to
c6c52c5
Compare
gkumbhat
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
TGISBackend.handle_runtime_context. This is a new API onBackendBaseintroduced in caikit in order to allowcaikit.runtimeto proactively notify configured backends of request contexts.NOTE: This PR does not bump the minimum version in
caikitbecause implementing this function does not require that there be a base implementation. If used with an older version ofcaikit, it simply won't get called.