-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reports_order for RT compliance to intended checks #2844
Conversation
Warehouse report 📦 DAGLegend (in order of precedence)
|
@lauriemerrell I'd love a quick review on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, re: testing you could add a few new tests here:
not_null
with awhere
clause and thefeature
is any of the features included in the reports siteunique_combination_of_columns
forfeature / reports_order
wherereports_order
is not null
And combined those tests would I think guarantee what you want.
Thanks @lauriemerrell, I added the simpler of the two checks you suggested for now (the other one required some workarounds as it would require using a custom macro in a place where dbt doesn't like macros. i'm happy with just this for now). |
* reports_order for RT compliance to intended checks * add one check for reports order
Description
One change I forgot to make before: adding reports_order for RT checks to intended checks. This is very straightforward.
Also fixed a typo in a check name.
Type of change
How has this been tested?
I spot checked to confirm that there's only one of each number added (from 0 to 15). Do you think I ought to rerun the whole model to test this?
Post-merge follow-ups
Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.