-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update undeploy.json with draft entry #637
Conversation
@@ -558,7 +558,8 @@ By default, `cds add hana` creates an `undeploy.json` like this: | |||
[ | |||
"src/gen/**/*.hdbview", | |||
"src/gen/**/*.hdbindex", | |||
"src/gen/**/*.hdbconstraint" | |||
"src/gen/**/*.hdbconstraint", | |||
"src/gen/**/*_drafts.hdbtable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this already valid or for the upcoming release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, has already been merged - see https://github.tools.sap/cap/cds-tools/issues/1065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, it's merged. But it's not yet released, right? There hasn't been a release in the past 5 days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I misunderstood your initial question:
Is this already valid or for the upcoming release?
It is valid for the upcoming release 7.6.0 - do I have to set some specific label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the "do not merge" label would be good. But as we are now approaching our next release, there's no need to hold it back. We can merge already.
No description provided.