Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update undeploy.json with draft entry #637

Merged
merged 2 commits into from
Jan 24, 2024
+2 −1
Merged

update undeploy.json with draft entry #637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa2b718
update undeploy.json with draft entry
LotharBender Jan 19, 2024
3fb67c8
Merge branch 'main' into undeployJsonWithDraft
LotharBender Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion guides/databases-hana.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,8 @@ By default, `cds add hana` creates an `undeploy.json` like this:
[
"src/gen/**/*.hdbview",
"src/gen/**/*.hdbindex",
"src/gen/**/*.hdbconstraint"
"src/gen/**/*.hdbconstraint",
"src/gen/**/*_drafts.hdbtable"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this already valid or for the upcoming release?

Copy link
Collaborator Author

@LotharBender LotharBender Jan 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, has already been merged - see https://github.tools.sap/cap/cds-tools/issues/1065

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it's merged. But it's not yet released, right? There hasn't been a release in the past 5 days.

Copy link
Collaborator Author

@LotharBender LotharBender Jan 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I misunderstood your initial question:

Is this already valid or for the upcoming release?

It is valid for the upcoming release 7.6.0 - do I have to set some specific label?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the "do not merge" label would be good. But as we are now approaching our next release, there's no need to hold it back. We can merge already.

]
```

Expand Down