Skip to content

feat(ui): Refactor redux for how we store all related data of existing identifiers #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Sotatek-DukeVu
Copy link
Collaborator

@Sotatek-DukeVu Sotatek-DukeVu commented Aug 1, 2025

Description

Refactor the Redux data structure: Currently, we will store information such as credentials, notifications, archived credentials, peer connections, and connections based on the profiles they were created under.

Note: At the moment, connections are still stored in a separate slice because the core function has not yet been updated to support storing individual connections per profile. We will update this later.

Checklist before requesting a review

Issue ticket number and link

  • This PR has a valid ticket number or issue: VT20-2014

Testing & Validation

  • This PR has been tested/validated in iOS, Android and browser.
  • Added new unit tests, if relevant.

Design Review

  • In case this PR contains changes to the UI, add some screenshots and/or videos to show the changes on relevant devices.
Screen.Recording.2025-08-01.at.18.05.13.mov

@Sotatek-DukeVu Sotatek-DukeVu marked this pull request as draft August 1, 2025 11:07
@Sotatek-DukeVu Sotatek-DukeVu self-assigned this Aug 1, 2025
@Sotatek-DukeVu Sotatek-DukeVu removed the request for review from sdisalvo-crd August 1, 2025 11:08
@Sotatek-DukeVu Sotatek-DukeVu changed the title feat(ui): feat(ui): Refactor redux for how we store all related data of existing identifiers Aug 1, 2025
@Sotatek-DukeVu Sotatek-DukeVu marked this pull request as ready for review August 1, 2025 11:47
Copy link
Contributor

@sdisalvo-crd sdisalvo-crd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, approving and merging into feature branch.

@sdisalvo-crd sdisalvo-crd merged commit c74ae0d into VT20-1965-profile-details-view Aug 1, 2025
1 check passed
@sdisalvo-crd sdisalvo-crd deleted the VT20-2014-refactor-redux-for-how-we-store-all-related-data-of-existing-identifiers branch August 1, 2025 13:59
@sdisalvo-crd sdisalvo-crd mentioned this pull request Aug 1, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants