Fix for below ground trigger boxes. (#9381)

* Fix for below ground trigger boxes.

* Adjusted trigger box for Town15

Author: GoodarzMehr

Unreal/CarlaUE4/Plugins/Carla/Source/Carla/MapGen/LargeMapManager.cpp

@@ -138,8 +138,8 @@ void ALargeMapManager::PostWorldOriginOffset(UWorld* InWorld, FIntVector InSrcOr
 
 bool ALargeMapManager::AdjustSignHeightToGround(FVector& SpawnLocation, const FString& ActorName, const TArray<AActor*>& ActorsToIgnore) const
 {
-  const FVector Start = SpawnLocation + FVector(0, 0, 10.0f);
-  const FVector End = SpawnLocation - FVector(0, 0, 20000.0f);
+  const FVector Start = SpawnLocation + FVector(0, 0, 200.0f);
+  const FVector End = SpawnLocation - FVector(0, 0, 10000.0f);
 
   FHitResult HitResult;
   FCollisionQueryParams CollisionParams;
@@ -177,12 +177,45 @@ void ALargeMapManager::AdjustAllSignsToHeightGround()
       continue;
     if (TrafficSign->bPositioned)
       continue;
-    FVector SpawnLocation = Actor->GetActorLocation();
-    TrafficSign->bPositioned = AdjustSignHeightToGround(SpawnLocation, Actor->GetName(), ActorsToIgnore);
-
-    Actor->GetRootComponent()->SetMobility(EComponentMobility::Movable);
-    Actor->SetActorLocation(SpawnLocation);
-    Actor->GetRootComponent()->SetMobility(EComponentMobility::Static);
+    FVector OriginalLocation = Actor->GetActorLocation();
+    FVector AdjustedLocation = OriginalLocation;
+    
+    TrafficSign->bPositioned = AdjustSignHeightToGround(AdjustedLocation, Actor->GetName(), ActorsToIgnore);
+    
+    if (TrafficSign->bPositioned)
+    {
+      float ZOffset = AdjustedLocation.Z - OriginalLocation.Z;
+
+      Actor->GetRootComponent()->SetMobility(EComponentMobility::Movable);
+      
+      // Get all static mesh components
+      TArray<UStaticMeshComponent*> StaticMeshComps;
+      Actor->GetComponents<UStaticMeshComponent>(StaticMeshComps);
+      
+      for (UStaticMeshComponent* MeshComp : StaticMeshComps)
+      {
+        if (!MeshComp) continue;
+        
+        // Skip if this has a mesh parent (it's a child)
+        USceneComponent* ParentComp = MeshComp->GetAttachParent();
+        if (ParentComp && Cast<UStaticMeshComponent>(ParentComp))
+        {
+          continue;
+        }
+        
+        // Move the mesh component down
+        FVector CompLocation = MeshComp->GetRelativeLocation();
+        CompLocation.Z += ZOffset;
+        MeshComp->SetRelativeLocation(CompLocation);
+        
+        MeshComp->UpdateBounds();
+        
+        LM_LOG(Log, "Moved mesh %s by %f cm", *Actor->GetName(), ZOffset);
+      }
+      
+      Actor->UpdateComponentTransforms();
+      Actor->GetRootComponent()->SetMobility(EComponentMobility::Static);
+    }
   }
 }
 

Unreal/CarlaUE4/Plugins/Carla/Source/Carla/Traffic/TrafficLightManager.cpp

@@ -266,11 +266,50 @@ void ATrafficLightManager::AdjustAllSignsToHeightGround()
 {
   for(ATrafficSignBase* TS : TrafficSigns)
   {
-    TS->GetRootComponent()->SetMobility(EComponentMobility::Movable);
-    FVector SpawnLocation = TS->GetActorLocation();
-    AdjustSignHeightToGround(SpawnLocation);
-    TS->SetActorLocation(SpawnLocation);
-    TS->GetRootComponent()->SetMobility(EComponentMobility::Static);
+    if (!IsValid(TS))
+      continue;
+    if (TS->bPositioned)
+      continue;
+
+    FVector OriginalLocation = TS->GetActorLocation();
+    FVector AdjustedLocation = OriginalLocation;
+    
+    TS->bPositioned = AdjustSignHeightToGround(AdjustedLocation);
+    
+    if (TS->bPositioned)
+    {
+      float ZOffset = AdjustedLocation.Z - OriginalLocation.Z;
+
+      TS->GetRootComponent()->SetMobility(EComponentMobility::Movable);
+      
+      // Get all static mesh components
+      TArray<UStaticMeshComponent*> StaticMeshComps;
+      TS->GetComponents<UStaticMeshComponent>(StaticMeshComps);
+      
+      for (UStaticMeshComponent* MeshComp : StaticMeshComps)
+      {
+        if (!MeshComp) continue;
+        
+        // Skip if this has a mesh parent (it's a child)
+        USceneComponent* ParentComp = MeshComp->GetAttachParent();
+        if (ParentComp && Cast<UStaticMeshComponent>(ParentComp))
+        {
+          continue;
+        }
+        
+        // Move the mesh component down
+        FVector CompLocation = MeshComp->GetRelativeLocation();
+        CompLocation.Z += ZOffset;
+        MeshComp->SetRelativeLocation(CompLocation);
+        
+        MeshComp->UpdateBounds();
+        
+        UE_LOG(LogCarla, Log, TEXT("Moved mesh %s by %f cm"), *TS->GetName(), ZOffset);
+      }
+      
+      TS->UpdateComponentTransforms();
+      TS->GetRootComponent()->SetMobility(EComponentMobility::Static);
+    }
   }
 }
 
@@ -909,7 +948,7 @@ void ATrafficLightManager::RemoveAttachedProps(TArray<AActor*> Actors) const
 
 bool ATrafficLightManager::AdjustSignHeightToGround(FVector& SpawnLocation) const
 {
-  const FVector Start = SpawnLocation + FVector(0, 0, 10.0f);
+  const FVector Start = SpawnLocation + FVector(0, 0, 200.0f);
   const FVector End = SpawnLocation - FVector(0, 0, 10000.0f);
 
   FHitResult HitResult;