-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Fix for the issues 9361, 9385 and 9387 #9380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d maintain box component locations
…ions during height adjustments
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes. |
Added new parameter for ActorInfo for the trigger volume. Now `get_trigger_volume` returns the real trigger volume
This reverts commit 8eb35ab.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glopezdiest reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Blyron)
445fe66
Add RegisterEnvironmentObjects method and update object registration logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glopezdiest reviewed 12 of 12 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Blyron)
Fix for issue #9362 was already merge in @GoodarzMehr PR #9381
Currently working on fix for issues #9361 #9385 and #9387
For the issue #9361 this is the current status.

In Green the bounding box returned by '.bounding_box' in the actor.
In Blue the bounding box returned by '.trigger_volume' in the actor.
In Gray the bounding box returned by 'bounding_box' in the environment object.
This is for a new issue. The bounding boxes for the actors in large maps are different with both calls. I saw this behavior only for the
Stop Signs.Script used for testing in the 'Town12'
Fixed the issue #9385.

Fixed the issue #9387

Script used to test these two issues.
This change is