Smoothed how the TrafficManager does turns #9395
Merged
+81
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed the target location used by the TrafficManager control to smooth the way turns are performed.
Currently, the road is divided into waypoints every 5m, reduced to 2-3m at turns. The MotionPlanStage selects one of these waypoints and uses is as the target. This creates sudden changes in the target yaw, making the control less smooth.
This PR makes it so that instead of targeting a specific waypoint, it interpolates between the two closest ones to that target distance, picking a location in between. The PR also changes the angular metric from the dot product to the angle. It doesn't really make that much of a difference control wise, but the dot product has a non-linear relation with the steering, while the angle has so it adds a bit of robustness..
Where has this been tested?
This change is