Skip to content

Conversation

@LuisPovedaCano
Copy link
Contributor

@LuisPovedaCano LuisPovedaCano commented Oct 29, 2025

This PR is related with this content PR

Problem

The prop factory was not working - props could not be spawned from the Python API. Attempting to spawn any prop would fail silently or return errors.

Root Cause

Three main issues prevented props from spawning:

  1. Missing Class Assignment: MakePropDefinition() in ActorBlueprintFunctionLibrary.cpp was not assigning Definition.Class, leaving it null. This caused SpawnActor() to fail the validity check.

  2. No Mesh Path Propagation: There was no mechanism to pass the mesh path from the prop definition to the spawner, making it impossible to load the correct mesh at spawn time.

  3. Incomplete SpawnActor Implementation: PropActorFactory::SpawnActor() returned UnknownError immediately without any actual spawning logic.

Testing

Tested in Ubuntu 22 in Town10.

Screenshot from 2025-10-29 18-48-40

This change is Reviewable

Enhance actor spawning logic in APropActorFactory with detailed error handling and component validation
@LuisPovedaCano LuisPovedaCano self-assigned this Oct 29, 2025
@LuisPovedaCano LuisPovedaCano requested a review from a team as a code owner October 29, 2025 18:00
@update-docs
Copy link

update-docs bot commented Oct 29, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update our CHANGELOG.md based on your changes.

@Blyron Blyron merged commit d86cc03 into ue5-dev Oct 30, 2025
1 check passed
@Blyron Blyron deleted the luis/prop_factory branch October 30, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants