Skip to content

Conversation

@pauladkisson
Copy link
Member

@pauladkisson pauladkisson commented Sep 30, 2024

Awaiting #366 then will change base to 0.6.0dev.

This PR is the third of a series that implement breaking changes to fully standardize the roiextractors api and update/streamline the testing suite. Some of the main goals include

  • removing channels argument to enforce 1 channel/extractor
  • Switching to modularized mixins for testing and supporting pytest fixtures/parameterization
  • Standard input validation, numpy indexing for 'get' methods, etc.

This PR adds a BaseExtractor class and corresponding BaseExtractorMixin testing mixin to contain commonalities between ImagingExtractor and SegmenationExtractor (mostly methods concerned with _times).

@pauladkisson pauladkisson changed the title Base extractor Add Base extractor Sep 30, 2024
@pauladkisson pauladkisson mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants