-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💚 Fix compilation of Python wheels for Windows #462
Conversation
bindings/pyfiction/test/algorithms/physical_design/test_design_sidb_gates.py
Fixed
Show fixed
Hide fixed
bindings/pyfiction/test/algorithms/simulation/sidb/test_operational_domain.py
Fixed
Show fixed
Hide fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #462 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 214 214
Lines 28876 28877 +1
Branches 1367 1367
=======================================
+ Hits 28361 28362 +1
Misses 515 515 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bindings/pyfiction/test/algorithms/simulation/sidb/test_time_to_solution.py
Fixed
Show fixed
Hide fixed
…to fix_wheel_test_issue_windows
Description
Github has released an update to MSVC v144 for the
windows-latest
runner. This could cause this problem as discussed here. So we have to usewindows-2019
until this is fixed.Checklist: