💚 Fix compilation of Python wheels for Windows

.github/workflows/pyfiction-pypi-deployment.yml

@@ -53,7 +53,7 @@ jobs:
           - { os: ubuntu-latest, arch: x64 }
           - { os: macos-latest, arch: x64 }
           - { os: macos-latest, arch: arm64 }
-          - { os: windows-latest, arch: x64 }
+          - { os: windows-2019, arch: x64 }
         python: ['cp38', 'cp39', 'cp310', 'cp311', 'cp312']
     steps:
       - uses: actions/checkout@v4

.github/workflows/python-bindings.yml

@@ -44,18 +44,24 @@ jobs:
   build_and_test:
     strategy:
       matrix:
-        os: [ ubuntu-latest, macos-latest, windows-latest ]
+        os: [ ubuntu-22.04, macos-14, windows-2019 ]
         python_version: [ '3.8.x', '3.12.x' ]
         include:
-          - os: ubuntu-latest
+          - os: ubuntu-22.04
             z3_platform: linux
             architecture: x64
-          - os: macos-latest
+            toolset: v142
+          - os: macos-14
             z3_platform: macOS
             architecture: arm64
-          - os: windows-latest
+          - os: windows-2019
             z3_platform: windows
             architecture: x64
+            toolset: v142
+          - os: windows-2019
+            z3_platform: windows
+            architecture: x64
+            toolset: v143
 
     name: 🐍 on ${{matrix.os}} with Python ${{matrix.python_version}}
     runs-on: ${{matrix.os}}
@@ -69,7 +75,7 @@ jobs:
       - name: Setup ccache
         uses: hendrikmuhs/[email protected]
         with:
-          key: '${{matrix.os}}-pyfiction'
+          key: '${{matrix.os}}-${{matrix.toolset}}-pyfiction'
           variant: ccache
           save: true
           max-size: 10G

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/quicksim.hpp

@@ -44,9 +44,7 @@ inline void quicksim(pybind11::module& m)
                        DOC(fiction_quicksim_params_iteration_steps))
         .def_readwrite("alpha", &fiction::quicksim_params::alpha, DOC(fiction_quicksim_params_alpha))
         .def_readwrite("number_threads", &fiction::quicksim_params::number_threads,
-                       DOC(fiction_quicksim_params_number_threads))
-
-        ;
+                       DOC(fiction_quicksim_params_number_threads));
 
     // NOTE be careful with the order of the following calls! Python will resolve the first matching overload!
 

bindings/pyfiction/test/algorithms/simulation/sidb/test_critical_temperature.py

@@ -61,7 +61,7 @@ def test_gate_based_simulation(self):
 
     def test_bestagon_inv(self):
         layout = read_sqd_layout_100(dir_path + "/../../../resources/hex_11_inputsdbp_inv_straight_v0_manual.sqd",
-                                 "inverter_input_0")
+                                     "inverter_input_0")
 
         params = critical_temperature_params()
         params.engine = simulation_engine.APPROXIMATE
@@ -78,7 +78,7 @@ def test_bestagon_inv(self):
 
     def test_bestagon_inv_with_different_mu(self):
         layout = read_sqd_layout_100(dir_path + "/../../../resources/hex_11_inputsdbp_inv_straight_v0_manual.sqd",
-                                 "inverter_input_0")
+                                     "inverter_input_0")
 
         params = critical_temperature_params()
         params.simulation_parameters.base = 2

test/benchmark/simulation.cpp

@@ -8,6 +8,7 @@
 #include <fiction/algorithms/simulation/sidb/quickexact.hpp>
 #include <fiction/algorithms/simulation/sidb/quicksim.hpp>
 #include <fiction/technology/cell_technologies.hpp>
+#include <fiction/traits.hpp>
 #include <fiction/types.hpp>
 
 using namespace fiction;
@@ -61,7 +62,7 @@ TEST_CASE("Benchmark simulators", "[benchmark]")
 
     BENCHMARK("QuickExact")
     {
-        const quickexact_params<lattice> sim_params{sidb_simulation_parameters{2, -0.32}};
+        const quickexact_params<cell<lattice>> sim_params{sidb_simulation_parameters{2, -0.32}};
         return quickexact<lattice>(lyt, sim_params);
     };