Skip to content

[feature/new-dag-editor] part 5: Add components for the DAG Nodes and Edges #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: feature/new-dag-editor
Choose a base branch
from

Conversation

GnsP
Copy link
Collaborator

@GnsP GnsP commented Mar 28, 2025

Add components for the DAG Nodes and Edges

Description

Part 5 of the set of changes implementing the new DAG editor for CDAP UI.

Links to the previous changesets:

  1. [feature/new-dag-editor] part 1: Add changes to the dag-plus directive #1309
  2. [feature/new-dag-editor] part 2: Add back the older my-dag-ctrl to keep supporting the older ui #1312
  3. [feature/new-dag-editor] part 3: update build configs and add reactflow as dependency #1313
  4. [feature/new-dag-editor] part 4: Add the main component for the reactflow based DAG editor #1316

In this PR, we add the react components for the DAG Nodes and DAG Edges to be used in the main reactflow component. These are similar to the nodes and edges in the older version of the editor with minor UI/UX differences. In most cases, these components are direct translations of the corresponding angularjs code to react. For ease of review, we are adding references to the corresponding angularjs directive and templates here.

References:

PR Type

  • Bug Fix
  • Feature
  • Build Fix
  • Testing
  • General Improvement
  • Cherry Pick

Links

Jira: CDAP-21142

Test Plan

NA. Not testable. Tests will be run when the complete feature branch is merged to develop

Screenshots

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants