[feature/new-dag-editor] part 5: Add components for the DAG Nodes and Edges#1317
Open
GnsP wants to merge 2 commits intocdapio:feature/new-dag-editorfrom
Open
[feature/new-dag-editor] part 5: Add components for the DAG Nodes and Edges#1317GnsP wants to merge 2 commits intocdapio:feature/new-dag-editorfrom
GnsP wants to merge 2 commits intocdapio:feature/new-dag-editorfrom
Conversation
Open
6 tasks
radhikav1
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add components for the DAG Nodes and Edges
Description
Part 5 of the set of changes implementing the new DAG editor for CDAP UI.
Links to the previous changesets:
In this PR, we add the react components for the DAG Nodes and DAG Edges to be used in the main reactflow component. These are similar to the nodes and edges in the older version of the editor with minor UI/UX differences. In most cases, these components are direct translations of the corresponding angularjs code to react. For ease of review, we are adding references to the corresponding angularjs directive and templates here.
References:
PR Type
Links
Jira: CDAP-21142
Test Plan
NA. Not testable. Tests will be run when the complete feature branch is merged to develop
Screenshots
NA