Skip to content

Conversation

@wallrj-cyberark
Copy link
Member

@wallrj-cyberark wallrj-cyberark commented Sep 12, 2025

  • Add logic to detect canceled context and avoid further reconcile attempts
  • Log context cancellation as info for diagnostics and apply patch before exit
  • Prevent logging expected context errors at error level during shutdown

xref:

/cc @FelixPhipps @inteon

…ries

- Add logic to detect canceled context and avoid further reconcile attempts
- Log context cancellation as info for diagnostics and apply patch before exit
- Prevent logging expected context errors at error level during shutdown

Signed-off-by: Richard Wall <[email protected]>
@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Sep 12, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 12, 2025
@cert-manager-prow
Copy link
Contributor

Hi @wallrj-cyberark. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 12, 2025
@wallrj-cyberark wallrj-cyberark changed the title fix(request_controller): handle canceled context to prevent extra retries [VC-35742] Handle canceled context to prevent extra retries Sep 12, 2025
@inteon
Copy link
Member

inteon commented Sep 15, 2025

@wallrj-cyberark normally, controller-runtime should have shutdown the queue resulting in no more retries after a context cancelation. There might be a slight delay, but that should not cause any issues afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants