Skip to content

[VC-35742] Handle canceled context to prevent extra retries #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[VC-35742] Handle canceled context to prevent extra retries #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions controllers/request_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,21 @@ func (r *RequestController) reconcileStatusPatch(
isPending := errors.As(err, pendingError)
isPermanentError := errors.As(err, &signer.PermanentError{})
pastMaxRetryDuration := r.Clock.Now().After(requestObject.GetCreationTimestamp().Add(r.MaxRetryDuration))
contextError := context.Cause(ctx)
contextIsDone := contextError != nil
switch {
case contextIsDone:
// The context has been cancelled. Probably because the process is shutting down.
// Return nil to prevent further reconcile attempts. Log the
// error at debug level as an info message for diagnostic purposes.
// We avoid logging the Sign error as an error because an error is
// expected if the supplied context has been cancelled. Here's an example of such an error:
// > failed to request venafi certificate: vcert error: server error:
// > server unavailable: Get
// > "https://api.venafi.cloud/outagedetection/v1/applications/tlspk-bench/certificateissuingtemplates/Default":
// > context canceled
logger.V(1).Info("Exiting", "reason", "context done", "signing-error", err)
return result, statusPatch, nil // apply patch, done
case isPending:
// Signing is pending, wait more.
//
Expand Down