test: migrate chromatic tests #1745

codemonkey800 · 2025-04-01T22:32:26Z

Migrates all of the E2E tests to start using chromatic
Remove calls to the API for testing and rely on chromatic snapshots to capture reference images with correct data instead
Refactor some API calls to use the V2 API

rainandbare · 2025-04-11T20:14:44Z

frontend/packages/data-portal/e2e/metadataDrawer.test.ts

+      await metadataDrawerPage.expectMetadataDrawerToBeHidden()
+    })
+
+    // test('metadata should have correct data', async ({ page }) => {


did you want this commented out still?

rainandbare

Looks good! There is just one failing test because I changed the title of the Download Dialogue. Thank you for doing this!

codemonkey800 requested review from rainandbare, ehoops-cz and bchu1 April 1, 2025 22:32

codemonkey800 temporarily deployed to local April 2, 2025 00:38 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local April 2, 2025 00:48 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local April 4, 2025 21:47 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local April 4, 2025 21:48 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 21:48 — with GitHub Actions Error

codemonkey800 temporarily deployed to local April 4, 2025 21:48 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 21:48 — with GitHub Actions Error

codemonkey800 added 16 commits April 4, 2025 15:11

carry over tests

7f9d494

browse datasets tests

c748181

download dialog tests

3453a7e

fix not defined error

009c68e

fix chromatic imports

9ff6229

fix unexpected test.beforeEach()

b3033ce

file format param

fd6e4ff

fix select copy button

bbb8167

metadata drawer e2e test

cb872b6

pagination e2e test

be9ef3d

single dataset filters e2e tests

13ef78d

single run e2e test

904ee75

single run filters e2e test

3c5128c

wait for table load after selecting / deselecting

53db652

more chromatic imports

fc64eec

fix snapshot for carry over tests

b3a111c

codemonkey800 force-pushed the jeremy/migrate-chromatic-tests branch from 4a7ffd4 to 027bab2 Compare April 4, 2025 22:11

codemonkey800 temporarily deployed to local April 4, 2025 22:11 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 22:13 — with GitHub Actions Error

codemonkey800 had a problem deploying to local April 4, 2025 22:13 — with GitHub Actions Failure

codemonkey800 temporarily deployed to local April 4, 2025 22:13 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 22:13 — with GitHub Actions Error

codemonkey800 temporarily deployed to local April 4, 2025 22:25 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local April 4, 2025 22:27 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 22:27 — with GitHub Actions Error

codemonkey800 temporarily deployed to local April 4, 2025 22:27 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 4, 2025 22:27 — with GitHub Actions Failure

fix type error

8bf3008

codemonkey800 force-pushed the jeremy/migrate-chromatic-tests branch from d65c4fe to 8bf3008 Compare April 5, 2025 03:08

codemonkey800 temporarily deployed to local April 5, 2025 03:08 — with GitHub Actions Inactive

codemonkey800 temporarily deployed to local April 5, 2025 03:09 — with GitHub Actions Inactive

codemonkey800 had a problem deploying to local April 5, 2025 03:09 — with GitHub Actions Failure

codemonkey800 temporarily deployed to local April 5, 2025 03:09 — with GitHub Actions Inactive

rainandbare reviewed Apr 11, 2025

View reviewed changes

rainandbare approved these changes Apr 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: migrate chromatic tests #1745

test: migrate chromatic tests #1745

codemonkey800 commented Apr 1, 2025

rainandbare Apr 11, 2025

rainandbare left a comment

test: migrate chromatic tests #1745

Are you sure you want to change the base?

test: migrate chromatic tests #1745

Conversation

codemonkey800 commented Apr 1, 2025

rainandbare Apr 11, 2025

Choose a reason for hiding this comment

rainandbare left a comment

Choose a reason for hiding this comment