Skip to content

test: migrate chromatic tests #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

test: migrate chromatic tests #1745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7f9d494
carry over tests
codemonkey800 Apr 4, 2025
c748181
browse datasets tests
codemonkey800 Apr 4, 2025
3453a7e
download dialog tests
codemonkey800 Apr 4, 2025
009c68e
fix not defined error
codemonkey800 Apr 4, 2025
9ff6229
fix chromatic imports
codemonkey800 Apr 4, 2025
b3033ce
fix unexpected test.beforeEach()
codemonkey800 Apr 4, 2025
fd6e4ff
file format param
codemonkey800 Apr 4, 2025
bbb8167
fix select copy button
codemonkey800 Apr 4, 2025
cb872b6
metadata drawer e2e test
codemonkey800 Apr 4, 2025
be9ef3d
pagination e2e test
codemonkey800 Apr 4, 2025
13ef78d
single dataset filters e2e tests
codemonkey800 Apr 4, 2025
904ee75
single run e2e test
codemonkey800 Apr 4, 2025
3c5128c
single run filters e2e test
codemonkey800 Apr 4, 2025
53db652
wait for table load after selecting / deselecting
codemonkey800 Apr 4, 2025
fc64eec
more chromatic imports
codemonkey800 Apr 4, 2025
b3a111c
fix snapshot for carry over tests
codemonkey800 Apr 4, 2025
8bf3008
fix type error
codemonkey800 Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/packages/data-portal/_templates/e2e/new/pageObject.cjs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
to: e2e/pageObjects/<%= name %>/<%= name %>Page.ts
---
import { expect } from '@playwright/test'
import { expect } from '@chromatic-com/playwright'
import { BasePage } from 'e2e/pageObjects/basePage'

export class <%= h.changeCase.pascal(name) %>Page extends BasePage {
Expand Down
2 changes: 1 addition & 1 deletion frontend/packages/data-portal/_templates/e2e/new/testFile.cjs.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
to: e2e/<%= name %>.test.ts
---
import { ApolloClient, NormalizedCacheObject } from '@apollo/client'
import { test } from '@playwright/test'
import { test } from '@chromatic-com/playwright'
import { <%= h.changeCase.pascal(name) %>Page } from 'e2e/pageObjects/<%= name %>/<%= name %>Page'

test.describe('<%= name %>', () => {
Expand Down
1 change: 0 additions & 1 deletion frontend/packages/data-portal/app/components/Filters/BooleanFilter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ export function BooleanFilter({
styles.boolean,
!wrapped && 'whitespace-nowrap',
wrapped && 'max-w-[185px]',
wrapped && styles.booleanWrapped,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this on purpose? I think we need this still.

)}
>
<InputCheckbox
Expand Down
8 changes: 4 additions & 4 deletions frontend/packages/data-portal/app/graphql/getDatasetsV2.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,16 +70,16 @@ const GET_DATASETS_QUERY = gql(`
`)

export async function getDatasetsV2({
page,
page = 1,
titleOrderDirection,
searchText,
params,
params = new URLSearchParams(),
client,
}: {
page: number
page?: number
titleOrderDirection?: OrderBy
searchText?: string
params: URLSearchParams
params?: URLSearchParams
client: ApolloClient<NormalizedCacheObject>
}): Promise<ApolloQueryResult<GetDatasetsV2Query>> {
return client.query({
Expand Down
4 changes: 2 additions & 2 deletions frontend/packages/data-portal/app/graphql/getRunByIdV2.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,15 +555,15 @@ export interface GetRunByIdV2Params {
client: ApolloClient<NormalizedCacheObject>
id: number
annotationsPage: number
params: URLSearchParams
params?: URLSearchParams
depositionId?: number
}

export async function getRunByIdV2({
client,
id,
annotationsPage,
params,
params = new URLSearchParams(),
depositionId,
}: GetRunByIdV2Params): Promise<ApolloQueryResult<GetRunByIdV2Query>> {
return client.query({
Expand Down
Loading
Loading