feat: use inhouse wcwidth package instead of go-runewidth #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change replaces the `go-runewidth` package with our in-house x/wcwidth package. This package is a simplified version of go-runewidth that uses the `golang.org/x/text` package for Unicode character width calculations. We also can't be using both go-runewidth and uniseg to calculate character widths, so we've removed the uniseg package as well. Otherwise, we might end up with inconsistent character width in terminals that don't support grapheme clusters.
caarlos0
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces the
go-runewidthpackage with our in-house x/wcwidth package. This package is a simplified version of go-runewidth that uses thegolang.org/x/textpackage for Unicode character width calculations.We also can't be using both go-runewidth and uniseg to calculate character widths, so we've removed the uniseg package as well. Otherwise, we might end up with inconsistent character width in terminals that don't support grapheme clusters.