Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use inhouse wcwidth package instead of go-runewidth #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: use inhouse wcwidth package instead of go-runewidth #643

wants to merge 1 commit into from

Commits on Oct 21, 2024

  1. feat: use inhouse wcwidth package instead of go-runewidth 

    This change replaces the `go-runewidth` package with our in-house
x/wcwidth package. This package is a simplified version of go-runewidth
that uses the `golang.org/x/text` package for Unicode character width
calculations.

We also can't be using both go-runewidth and uniseg to calculate
character widths, so we've removed the uniseg package as well.
Otherwise, we might end up with inconsistent character width
in terminals that don't support grapheme clusters.
    @aymanbagabas
    aymanbagabas committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7623152 View commit details
    Browse the repository at this point in the history