fix(openaicompat): handle cerebras/glm-4.6 thinking#83
Closed
Amolith wants to merge 1 commit intocharmbracelet:mainfrom
Closed
fix(openaicompat): handle cerebras/glm-4.6 thinking#83Amolith wants to merge 1 commit intocharmbracelet:mainfrom
Amolith wants to merge 1 commit intocharmbracelet:mainfrom
Conversation
Adds GetReasoning method to handle different providers using either 'reasoning' or 'reasoning_content' field names. So far, Cerebras is the only one I've noticed using this structure. https://inference-docs.cerebras.ai/capabilities/reasoning Assisted-by: GLM 4.6 via Crush
Contributor
Author
|
At first I thought the failing tests were expected because we're now passing |
Contributor
|
@Amolith to make reasoning work than for cerebras we need to handle reasoning content different so yeah we would need to create a new provider with new hooks so we include reasoning in the content. |
Contributor
Author
|
Closing this to fix it differently as a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GetReasoning method to handle different providers using either
reasoningorreasoning_contentfield names. So far, Cerebras is the only one I've noticed using this structure.https://inference-docs.cerebras.ai/capabilities/reasoning
Assisted-by: GLM 4.6 via Crush
CONTRIBUTING.md.